Kaw v0.13.0 #699
Merged
Kaw v0.13.0 #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The certificate overlap mechanism is implemented like renewBefore from cert-manager. Signed-off-by: Quique Llorente <[email protected]>
kubevirt-bot
added
release-note
qinqon
requested review from
phoracek
and removed request for
AlonaKaplan and
oshoval
rhrazdil
requested changes
Feb 24, 2021
|
/retest |
The kube-admission-webhook v0.13.0 use CertOverlapInterval as the moment when certificates has to start to rotate before the current certificate expiration time, this change reduce CertOverlapInterval and CARotateInterval to take that into account. Signed-off-by: Quique Llorente <[email protected]>
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
|
@qinqon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
What this PR does / why we need it:
The certificate overlap mechanism is implemented like renewBefore from
cert-manager.
Special notes for your reviewer:
Release note: