-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken URL in comment #692
Conversation
Hi @avishayt. Thanks for your PR. I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm thanks ! |
/override pull-kubernetes-nmstate-e2e-handler-k8s-future |
@qinqon: Overrode contexts on behalf of qinqon: pull-kubernetes-nmstate-e2e-handler-k8s-future In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@avishayt can you fix DCO with |
Signed-off-by: Avishay Traeger <[email protected]>
63c4ce7
to
2bf4ca0
Compare
Sorry, forgot Signed-off-by, please LGTM again |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@avishayt: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Is this a BUG FIX or a FEATURE ?:
/kind bug
What this PR does / why we need it:
There is a broken URL, this fixes it
Special notes for your reviewer:
Release note: