-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added owner reference for nns to node #211
Conversation
Hello contributor, thanks for submitting a PR for this project! I am the bot who triggers "standard-CI" builds for this project. In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a reason why we update the go modules on this PR?
Oh, no. Sorry I forgot to delete unused import. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested manually. (We can add a test removing Nodes, but we don't know how to add them back)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see a change in the lock file.
I think you need to revert this also or the lock file will not be in sync
@phoracek I think the best solution for this is to create another lane in the STD-CI with just one test (ginkgo focus) to remove the node. |
@SchSeba it looks like there was an issue with the lock before and we just randomly fixed it here by running |
ci test please |
1 similar comment
ci test please |
@SchSeba let's do the test :) thanks for not letting me to be lazy |
ci test please |
ci test please |
Signed-off-by: Petr Horacek <[email protected]>
ci test please |
…-pick-210-to-release-4.9 [release-4.9] Sync Dockerfile.openshift with u/s
Resolves #13