Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update verbosity of periodic logs from production to debug #205

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Update verbosity of periodic logs from production to debug #205

merged 1 commit into from
Oct 7, 2019

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Oct 7, 2019 •
edited
Loading

In order to avoid spamming the logs when we are on "production" verbosity level

@ovirt-infra
Copy link
Member

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow add status object to NodeNetworkState with nmstate error #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@oshoval
Copy link
Collaborator Author

oshoval commented Oct 7, 2019

hmm i am not whitelisted yet ?
(yesterday saw you added)

qinqon
qinqon previously approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinqon
Copy link
Member

qinqon commented Oct 7, 2019

ci test please

SchSeba
SchSeba previously approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: can you please write a better description than my name in the PR?

@oshoval oshoval dismissed stale reviews from SchSeba and qinqon via dd91bae October 7, 2019 11:35
@phoracek
Copy link
Member

phoracek commented Oct 7, 2019

ci add to whitelist

@phoracek
Copy link
Member

phoracek commented Oct 7, 2019

ci test please

@phoracek phoracek merged commit 06dded4 into nmstate:master Oct 7, 2019
cybertron pushed a commit to cybertron/kubernetes-nmstate that referenced this pull request Aug 27, 2021
@openshift-ci
Merge pull request nmstate#205 from jupierce/fix_master
5cc2b60 
name replacement must exactly match string in CSV
@kubevirt-bot kubevirt-bot mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek approved these changes

@SchSeba SchSeba SchSeba left review comments

@qinqon qinqon qinqon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oshoval @ovirt-infra @qinqon @phoracek @SchSeba