Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for vlan 1 flags #201

Merged
merged 3 commits into from
Oct 4, 2019
Merged

Added check for vlan 1 flags #201

merged 3 commits into from
Oct 4, 2019

Conversation

pitiK3U
Copy link
Contributor

@pitiK3U pitiK3U commented Oct 2, 2019

Resolves #174

phoracek
phoracek requested changes Oct 2, 2019
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some leftover comment.

We should make sure this check fails in case the VLAN is not configured as expected. Let's check it on friday.

test/e2e/utils.go Outdated Show resolved Hide resolved
@phoracek phoracek merged commit 8ec6e43 into nmstate:master Oct 4, 2019
rhrazdil pushed a commit to rhrazdil/kubernetes-nmstate that referenced this pull request Sep 3, 2021
@openshift-merge-robot
Merge pull request nmstate#201 from multi-arch/master
0008237 
Bug 1987136: Declare supported arches in CSV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check vlan 1 PVID egress untagged is set at linux-bridge ports
2 participants
@pitiK3U @phoracek