Reset dersired state after each test #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoracek
reviewed
Oct 2, 2019
| @@ -215,6 +219,7 @@ var _ = Describe("NodeNetworkState", func() { | |||
| for _, node := range nodes { | |||
| interfacesNameForNode(node).ShouldNot(ContainElement("bond1")) | |||
| } | |||
| resetDesiredStateForNodes() | |||
There was a problem hiding this comment.
Can't we do it in module-wide (or even better, package-wide) AfterEach?
There was a problem hiding this comment.
well we don't control what afterEach come last..., prefer to do this way to be sure that this is the last thing is called.
There was a problem hiding this comment.
Fine with me. Would you just add a TODO to resetDesiredStateForNodes mentioning that we should drop it once Policy cleans up the state?
|
ci test please |
1 similar comment
|
ci test please |
qinqon
force-pushed
the
reset_dersired_state_after_each_test
branch
from
93ae284 to
7b68519
Compare
…test - We have the --no-commit at leftover from another PR that we split, so we have to remove it - do desiredState cleanup at AfterEach - Use unique name for bridge and bond per test so failures at tearDown does not affect the other tests Signed-off-by: Quique Llorente <[email protected]>
qinqon
force-pushed
the
reset_dersired_state_after_each_test
branch
from
7b68519 to
893cbc6
Compare
phoracek
approved these changes
Oct 3, 2019
cybertron
pushed a commit
to cybertron/kubernetes-nmstate
that referenced
this pull request
Jul 30, 2021
Set default bundle channel to 4.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.