Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stability issues at e2e tests #191

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Sep 30, 2019

Signed-off-by: Quique Llorente [email protected]

stdci.yaml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
test/e2e/nns_conditions_test.go Outdated Show resolved Hide resolved
test/e2e/default_bridged_network_test.go Show resolved Hide resolved
test/e2e/default_bridged_network_test.go Show resolved Hide resolved
test/e2e/default_bridged_network_test.go Outdated Show resolved Hide resolved
test/e2e/default_bridged_network_test.go Show resolved Hide resolved
- Increase golang test timeout to 40m, we have a lot of Eventuallies now and we
  don't want a panic message.
- Mark as "pending" the default bridge network test, we need more time
  to debug why node is not going back to live at stdci + kubevirtci
- Make Client.Get for nodes honor Eventually timeout and interval values.

Signed-off-by: Quique Llorente <[email protected]>
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phoracek
Copy link
Member

There are more failing tests, but this PR does not cause any regressions. LGTM

@phoracek phoracek merged commit 56c71e1 into nmstate:master Sep 30, 2019
cybertron pushed a commit to cybertron/kubernetes-nmstate that referenced this pull request Jun 8, 2021
Bug 1954309: Rebase to upstream 0.47.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants