Clean up test logs #190
Merged
Clean up test logs #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoracek
requested changes
Sep 30, 2019
| @@ -223,7 +223,7 @@ func run(node string, command ...string) (string, error) { | |||
| cmd.Stderr = &stderr | |||
| cmd.Stdout = &stdout | |||
| err := cmd.Run() | |||
| GinkgoWriter.Write([]byte(stdout.String() + stderr.String() + "\n")) | |||
| GinkgoWriter.Write([]byte(fmt.Sprintf("stdout: %.500s...\n, stderr %s\n", stdout.String(), stderr.String()))) | |||
There was a problem hiding this comment.
do you think it would be worth setting this via an environment variable?
There was a problem hiding this comment.
Let's do like this, in case of error vlans are show in full so we are good, another option is to dump to files the full output and print the truncated ones.
qinqon
force-pushed
the
clean_up_test_logs
branch
from
e084128 to
9845aab
Compare
phoracek
previously approved these changes
Sep 30, 2019
|
qinqon
force-pushed
the
clean_up_test_logs
branch
from
9845aab to
5e8974f
Compare
|
@phoracek fixed, ReplaceAll is not at golang 1.11 |
phoracek
approved these changes
Sep 30, 2019
cybertron
pushed a commit
to cybertron/kubernetes-nmstate
that referenced
this pull request
Aug 27, 2021
UPSTREAM: <carry>: Add manifests to .PHONY in Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.