fix linux bridge cleanup #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bridge setup fails, nmstate sometimes leaves its netlink iface behind although it removes the connection. This issue is tracked in nmstate/nmstate#516. Until that gets resolved, we fix it with ugly sed workaround. Signed-off-by: Petr Horacek <[email protected]>
|
we have see some failures at the bridge still there even with this fix, but it can be other scenarios where we don't do a proper "absent" state instead of bad setup. |
|
ci test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bridge setup fails, nmstate sometimes leaves its netlink iface
behind although it removes the connection. This issue is tracked in
nmstate/nmstate#516. Until that gets
resolved, we fix it with ugly sed workaround.
Signed-off-by: Petr Horacek [email protected]