NodeSelector change does not trigger reconcile #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `nodeSelector` is changed and it matches a new node, this node ignores it. This issue was caused by reconcile predicate `UpdateFunc` callback depending on matching the node with both the new and the old policy `nodeSelector`. This caused `UpdateFunc` to not work properly. Now we check our node only against the new (updated) policy `nodeSelector`. Signed-off-by: HlinaCZ <[email protected]>
Signed-off-by: Petr Horacek <[email protected]>
phoracek
approved these changes
Sep 27, 2019
|
Stuck on default network test, the rest looks fine. |
cybertron
pushed a commit
to cybertron/kubernetes-nmstate
that referenced
this pull request
Apr 9, 2021
Add manifests for 4.8
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
nodeSelectoris changed and it matches a new node, this node ignores it.This issue was caused by reconcile predicate
UpdateFunccallback depending onmatching the node with both the new and the old policy
nodeSelector. Thiscaused
UpdateFuncto not work properly.Now we check our node only against the new (updated) policy
nodeSelector.Resolves #180
Signed-off-by: HlinaCZ [email protected]