Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moving route ip to bridge test #176

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Sep 20, 2019

It should fix the moving defout route ip to bridge test

@qinqon qinqon requested a review from phoracek September 20, 2019 13:01
@qinqon qinqon force-pushed the fix_default_bridge_test branch from 259ddd7 to be3d3ad Compare September 20, 2019 13:03
@phoracek
Copy link
Member

@qinqon do you want to change to k8s-1.15.1 now? Would need some automation/ renaming and stuff.

@qinqon
Copy link
Member Author

qinqon commented Sep 20, 2019

@phoracek just updating kubevirtci here to see if my local results are same at stdci

@qinqon qinqon force-pushed the fix_default_bridge_test branch 3 times, most recently from 7284556 to 94efad3 Compare September 20, 2019 14:27
@qinqon qinqon changed the title Upgrade kubevirtci Fix moving route ip to bridge test Sep 20, 2019
@qinqon qinqon force-pushed the fix_default_bridge_test branch 2 times, most recently from 9b1229d to 23bfd3d Compare September 20, 2019 14:32
@phoracek
Copy link
Member

@qinqon looks like it fails only due to focus, the test has passed

By("Remove the policy")
deletePolicy("default-network")
})

It("should successfully move default IP address on top of the bridge", func() {
FIt("should successfully move default IP address on top of the bridge", func() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove focus

@phoracek
Copy link
Member

OpenShift timed out on tests initialization @qinqon

*** Test killed with quit: ran too long (10m0s).

SchSeba
SchSeba previously approved these changes Sep 22, 2019
Copy link
Contributor

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

please just change the default time for the tests to maybe 30min ?

@phoracek
Copy link
Member

@SchSeba it did not time out on tests. It stuck before any test was executed. That has to be resolved before we merge.

@qinqon
Copy link
Member Author

qinqon commented Sep 23, 2019

Locally is working fine with os-3.11.0, have added ginkgo verbose just to stdci.

@qinqon
Copy link
Member Author

qinqon commented Sep 23, 2019

ci test please

@qinqon
Copy link
Member Author

qinqon commented Sep 23, 2019

k8s has just fail eth0 interface was not there before start the test, let's re-run to check instabilities.

@qinqon qinqon force-pushed the fix_default_bridge_test branch 5 times, most recently from 679e700 to 75f7a9c Compare September 24, 2019 10:48
@qinqon qinqon requested a review from SchSeba September 24, 2019 12:04
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

automation/test.sh Outdated Show resolved Hide resolved
@qinqon qinqon force-pushed the fix_default_bridge_test branch from 75f7a9c to 3e7166e Compare September 24, 2019 12:26
@qinqon qinqon requested a review from phoracek September 24, 2019 12:28
@qinqon qinqon force-pushed the fix_default_bridge_test branch from 3e7166e to 229cfe6 Compare September 24, 2019 13:23
phoracek
phoracek previously approved these changes Sep 24, 2019
@phoracek
Copy link
Member

@qinqon it failed os-3.11 CI. I think that skipping a test causes ginkgo to fail.

@qinqon
Copy link
Member Author

qinqon commented Sep 24, 2019

@phoracek os is timing out checking vlan_filtering 1 at one of the test... good tihng is that k8s is passing as expected, now I don't know what to do though.

@phoracek
Copy link
Member

@qinqon drop OS completely?

@qinqon
Copy link
Member Author

qinqon commented Sep 24, 2019

@phoracek k8s is failing now

- Upgrade kubevirtci, has some fixes for tun/tap qemu interfaces
- Fix vlans check
- Make ginkgo verbose at stdci
@phoracek
Copy link
Member

@qinqon please post new changes in new commits, Petr is too lazy to look for what has changed 😁

@qinqon
Copy link
Member Author

qinqon commented Sep 24, 2019

@phoracek
Copy link
Member

@qinqon whaaaaat! Thanks.

@phoracek
Copy link
Member

Passed, nice, merging.

@phoracek phoracek merged commit 0eb8f6c into nmstate:master Sep 24, 2019
bcrochet pushed a commit to bcrochet/kubernetes-nmstate that referenced this pull request Dec 5, 2020
[CARRY] Add cluster rules for nmstate-handler sa
@kubevirt-bot kubevirt-bot mentioned this pull request Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants