-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix moving route ip to bridge test #176
Conversation
259ddd7
to
be3d3ad
Compare
@qinqon do you want to change to k8s-1.15.1 now? Would need some automation/ renaming and stuff. |
@phoracek just updating kubevirtci here to see if my local results are same at stdci |
7284556
to
94efad3
Compare
9b1229d
to
23bfd3d
Compare
@qinqon looks like it fails only due to focus, the test has passed |
By("Remove the policy") | ||
deletePolicy("default-network") | ||
}) | ||
|
||
It("should successfully move default IP address on top of the bridge", func() { | ||
FIt("should successfully move default IP address on top of the bridge", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove focus
OpenShift timed out on tests initialization @qinqon
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
please just change the default time for the tests to maybe 30min ?
@SchSeba it did not time out on tests. It stuck before any test was executed. That has to be resolved before we merge. |
9763f83
to
510bed7
Compare
Locally is working fine with os-3.11.0, have added ginkgo verbose just to stdci. |
ci test please |
k8s has just fail eth0 interface was not there before start the test, let's re-run to check instabilities. |
679e700
to
75f7a9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit
75f7a9c
to
3e7166e
Compare
3e7166e
to
229cfe6
Compare
@qinqon it failed os-3.11 CI. I think that skipping a test causes ginkgo to fail. |
@phoracek os is timing out checking vlan_filtering 1 at one of the test... good tihng is that k8s is passing as expected, now I don't know what to do though. |
@qinqon drop OS completely? |
@phoracek k8s is failing now |
- Upgrade kubevirtci, has some fixes for tun/tap qemu interfaces - Fix vlans check - Make ginkgo verbose at stdci
229cfe6
to
28fd013
Compare
@qinqon please post new changes in new commits, Petr is too lazy to look for what has changed 😁 |
@phoracek you can clieck "foce pushed" so you get the changes only |
@qinqon whaaaaat! Thanks. |
Passed, nice, merging. |
[CARRY] Add cluster rules for nmstate-handler sa
It should fix the moving defout route ip to bridge test