Set vlan_filtering 1 at linux-bridge without ports #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qinqon unit tests failed |
|
@qinqon there was a panic in the test run |
qinqon
force-pushed
the
vlan_filtering_no_ports
branch
from
02aa1e4 to
3953fef
Compare
qinqon
force-pushed
the
vlan_filtering_no_ports
branch
from
3953fef to
6381d55
Compare
|
I am using this PR to add some refactoring to e2e tests also skipping default bridge test since it's not working as expected. |
|
ci test please |
qinqon
force-pushed
the
vlan_filtering_no_ports
branch
2 times, most recently
from
79d621d to
6af73d7
Compare
|
Can you please rebase? |
This PR add vlanfiltering_flag even if there is not port configured at the linux bridge in the desiredState. This is necessary in case ports are added outside of nmstate (linux bridge CNI) and vlan communicatoin and filtering is needed Signed-off-by: Quique Llorente <[email protected]>
qinqon
force-pushed
the
vlan_filtering_no_ports
branch
from
6af73d7 to
c03f768
Compare
phoracek
approved these changes
Sep 20, 2019
bcrochet
pushed a commit
to bcrochet/kubernetes-nmstate
that referenced
this pull request
Dec 3, 2020
Remove duplicated 'certified' key in CSV
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add vlanfiltering_flag even if there is not port configured at the
linux bridge in the desiredState.
This is necessary in case ports are added outside of nmstate (linux bridge CNI) and vlan
communicatoin and filtering is needed
Signed-off-by: Quique Llorente [email protected]