Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnneded linux bridge stp attributes #168

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Sep 10, 2019

With the latest version from nmstate if stp is not enabled the
stp attributes at linux bridge port are not mandatory.

With the latest version from nmstate if stp is not enabled the
stp attributes at linux bridge port are not mandatory.
@qinqon qinqon requested a review from phoracek September 10, 2019 14:49
@qinqon
Copy link
Member Author

qinqon commented Sep 10, 2019

If this passes we can close nmstate/nmstate#443.

Copy link
Contributor

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phoracek phoracek merged commit d987ff7 into nmstate:master Sep 11, 2019
bcrochet pushed a commit to bcrochet/kubernetes-nmstate that referenced this pull request Nov 25, 2020
@kubevirt-bot kubevirt-bot mentioned this pull request Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants