Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e, handler: Check neighbors at lldp test #1236

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Apr 29, 2024

What this PR does / why we need it:
Start lldpd at a node and check that neighbors get reported at nns at the enabled LLDP test.

Closes https://issues.redhat.com/browse/CNV-30149

Release note:

Check neighbors at e2e handler lldp test.

Start lldpd at a node and check that neighbors get reported at nns at
the enabled LLDP test.

Signed-off-by: Enrique Llorente <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 29, 2024
@qinqon qinqon requested review from mkowalski and removed request for rhrazdil and RamLavi April 29, 2024 10:07
@qinqon
Copy link
Member Author

qinqon commented Apr 29, 2024

/retest

Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@kubevirt-bot
Copy link
Collaborator

@maiqueb: changing LGTM is restricted to collaborators

In response to this:

Thank you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@qinqon
Copy link
Member Author

qinqon commented Apr 29, 2024

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@kubevirt-bot kubevirt-bot merged commit 6ac1567 into nmstate:main Apr 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants