Skip to content

Commit

Permalink
Run default bridge test at different job (#203)
Browse files Browse the repository at this point in the history
This job is instable now, but we don't want to skip running it
at the PRs, also if it fails it will break all the other tests.

Signed-off-by: Quique Llorente <[email protected]>
  • Loading branch information
qinqon authored and phoracek committed Oct 8, 2019
1 parent 06dded4 commit 755253b
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 9 deletions.
1 change: 1 addition & 0 deletions automation/check-patch.k8s-1.14.6.default-bridge.mounts
1 change: 1 addition & 0 deletions automation/check-patch.k8s-1.14.6.default-bridge.packages
1 change: 1 addition & 0 deletions automation/check-patch.k8s-1.14.6.default-bridge.sh
7 changes: 4 additions & 3 deletions automation/check-patch.sh
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
#!/bin/bash -xe

main() {
TARGET="$0"
TARGET="${TARGET#./}"
export SCRIPT_NAME="$0"

TARGET="${SCRIPT_NAME#./}"
TARGET="${TARGET%.*}"
TARGET="${TARGET#*.}"
TARGET="${TARGET//[.]default-bridge/}"
echo "TARGET=$TARGET"
export TARGET

echo "Setup Go paths"
cd ..
export GOROOT=/usr/local/go
Expand Down
11 changes: 6 additions & 5 deletions automation/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@ make cluster-up
make cluster-sync
test_args="-ginkgo.noColor"
skip_tests=""
skip_tests=""

# FIXME: Delete it when we migrate to okd4 provider, since os-3.11.0 is not
# working alright I we don't want to debug not supported providers.
if [[ $KUBEVIRT_PROVIDER =~ os- ]]; then
skip_tests="move.*default.*IP"
if [[ $SCRIPT_NAME =~ default-bridge ]]; then
focus_test=".*move.*default.*IP.*"
else
skip_tests=".*move.*default.*IP.*"
fi

make E2E_TEST_EXTRA_ARGS="$test_args" E2E_TEST_SKIP="$skip_tests" test/e2e
make E2E_TEST_EXTRA_ARGS="$test_args" E2E_TEST_FOCUS="$focus_tests" E2E_TEST_SKIP="$skip_tests" test/e2e
1 change: 1 addition & 0 deletions stdci.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
sub-stages:
- k8s-1.14.6.default-bridge
- k8s-1.14.6
- os-3.11.0

Expand Down
2 changes: 1 addition & 1 deletion test/e2e/default_bridged_network_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
)

// FIXME: We have to fix this test https://github.com/nmstate/kubernetes-nmstate/issues/192
var _ = PDescribe("NodeNetworkConfigurationPolicy default bridged network", func() {
var _ = Describe("NodeNetworkConfigurationPolicy default bridged network", func() {
createBridgeOnTheDefaultInterface := nmstatev1alpha1.State(`interfaces:
- name: brext
type: linux-bridge
Expand Down

0 comments on commit 755253b

Please sign in to comment.