Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code comments that python filter works slow in multi-threaded mode #433

Merged
merged 2 commits into from
Jan 15, 2023

Conversation

dyashuni
Copy link
Contributor

@dyashuni dyashuni commented Jan 14, 2023

Add warning that python filter works slow in multi-threaded mode

Edit:

  • added comments with warnings in examples
  • added examples to CI test

@yurymalkov
Copy link
Member

I can imagine a scenario where a user is overwhelmed with those warning messages.
I guess we can put a condition that we show it only once index and/or we can add log levels, though that would require some designing.

@yurymalkov yurymalkov changed the title Add warning that python filter works slow in multi-threaded mode Add code comments that python filter works slow in multi-threaded mode Jan 15, 2023
@yurymalkov yurymalkov merged commit 2175362 into nmslib:develop Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants