Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes made to the data used to populate Menu.fields isn't picked up by Menu.display #65

Open
nmlorg opened this issue Jul 15, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@nmlorg
Copy link
Owner

nmlorg commented Jul 15, 2019

Breaking this off from #63-511009850:

This also exposes the general issue that whenever menu.fields changes (either by having a field added/removed during processing, or by having its desc change), that change does not get picked up automatically if/when we call menu.display. The latter (desc changing) might suggest we should have desc be a callable, to both skip calculation if it's unnecessary (if we enter a msg.action-setting handler) and defer it (if it is necessary) until any handlers/local logic have made changes to the data. The former (fields being added/removed), however, goes back to suggesting that fields itself should be callable, and/or some kind of reusable generator.

@nmlorg nmlorg added the bug Something isn't working label Jul 15, 2019
@nmlorg nmlorg self-assigned this Jul 15, 2019
nmlorg added a commit that referenced this issue Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant