Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depends_on_tmb option to r cmd check. #106 #107

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

k-doering-NOAA
Copy link
Collaborator

This addresses #106.

Basically, it adds an option called depends_on_tmb to the r-cmd-check workflow that downloads the source version of Matrix on Mac and Windows to solve a complicated issue that affects TMB models. See more details in this google groups thread.

Here's an example workflow that calls r-cmd-check with the depends_on_tmb option set to true (note: replace @main with @depends-on-tmb to test the changes on this branch:

# Run r cmd check
name: call-r-cmd-check
on:
  push:
jobs:
  call-workflow:
    uses: nmfs-fish-tools/ghactions4r/.github/workflows/r-cmd-check.yml@main
    with:
      depends_on_tmb: true

@k-doering-NOAA
Copy link
Collaborator Author

@Andrea-Havron-NOAA this is ready to test! Also, if you could look through the code changes, too, that would be great. Feel free to note anything that doesn't seem right, or if you think some names should be changed (e.g., we don't need to call this option depends_on_tmb if there is a better idea).

Note: I do need to document this option on the readme.

Copy link

@Andrea-Havron-NOAA Andrea-Havron-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on clustTMB and the r-cmd-check github action now passes. The calc-coverage gha is still failing due to the same Matrix/TMB version conflict. A similar fix will need to be applied for that workflow, but this can be made a separate issue.

@k-doering-NOAA
Copy link
Collaborator Author

@Andrea-Havron-NOAA thanks for testing! I'll go ahead and merge this in and make a new issue for the calc coverage workflow.

@k-doering-NOAA k-doering-NOAA merged commit 6ef9bfe into main Jan 19, 2024
9 checks passed
@k-doering-NOAA k-doering-NOAA deleted the depends-on-tmb branch January 19, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants