Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Docker Support #84

Merged
merged 6 commits into from
Oct 7, 2021
Merged

Conversation

1600dolo
Copy link
Contributor

@1600dolo 1600dolo commented Sep 28, 2021

Hey,

Thanks for making this project! I saw #68 and wanted to pitch in a little. As someone who knows ~nothing about Svelte, I thought this post was pretty helpful.

I think this is a sane enough starting point for anyone who wants to run this as a container.

  • Adds a few new supporting commands that can be invoked by npm run ...
  • Creates a really simple Dockerfile. This could be fancier with env vars, multi-stage build, etc
  • Switches between adapter types based on an env var. It's not perfect but it should do

@vercel
Copy link

vercel bot commented Sep 28, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @nmelhado on Vercel.

@nmelhado first needs to authorize it.

@nmelhado
Copy link
Owner

nmelhado commented Oct 1, 2021

Thanks for this! I am going to try and take a look in the next week or so. A bunch of people will be very happy to have this added.

@vercel
Copy link

vercel bot commented Oct 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nmelhado/legends-league/9VnvUDe67Ac49L8pXu8oSqstdxVW
✅ Preview: https://legends-league-git-fork-1600dolo-dolo-containerize-nmelhado.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants