Adding support for NTLMv2 #79
Conversation
|
@nmarus @kcastrotech We've been using this for a while now and think it's a good change. |
|
Cool! Code looks good, I'll test it out internally. |
|
@kcastrotech hey, wondering if any updates on this? thanks! |
|
Hello @nmarus @ricjd @kcastrotech I have been using this module. But have to upgrade to NTLMv2. Please consider merging this PR to main branch. I have been trying other EWS modules that supports NTLMv2 but does not support HTML and other important features. |
| - Connects to configured EWS Host and downloads it's WSDL file so it might be concluded that this is "fairly" version agnostic | ||
| - After downloading the WSDL file, the wrapper dynamically exposes all EWS SOAP functions | ||
| - Attempts to standardize Microsoft's WSDL by modifying the file to include missing service name, port, and bindings | ||
| - This DOES NOT work with anything Microsoft Documents as using the EWS Managed API. | ||
| - When using NTLMv2 you have to you your Windows username and not your email address |
There was a problem hiding this comment.
| - When using NTLMv2 you have to you your Windows username and not your email address | |
| - When using NTLMv2 you have to use your Windows username and not your email address |
| username: config.username, | ||
| password: config.password, | ||
| domain: config.domain, | ||
| worksstation: config.worksstation, |
There was a problem hiding this comment.
| worksstation: config.worksstation, | |
| workstation: config.workstation, |
| This utilizes the [options](https://github.com/SamDecrock/node-http-ntlm#options) available to the underlying NTLM lib. | ||
| [Here](https://github.com/SamDecrock/node-http-ntlm#pre-encrypt-the-password) is an example from its README. |
There was a problem hiding this comment.
You should replace this old documentation with a reference to the docs for the new library you're using, so that users understand what options to pass in (e.g. they wouldn't know about an option like workstation unless it was documented here).
| nt_password: ntHashedPassword, | ||
| lm_password: lmHashedPassword, |
There was a problem hiding this comment.
If this is no longer supported, then this is a breaking change and you'll need to bump the version to 4.0.0
No description provided.