Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement *_{add,sub}_{signed,unsigned} methods. #24

Closed
nlordell opened this issue Jan 3, 2023 · 3 comments · Fixed by #29
Closed

Implement *_{add,sub}_{signed,unsigned} methods. #24

nlordell opened this issue Jan 3, 2023 · 3 comments · Fixed by #29
Labels
good first issue Good for newcomers

Comments

@nlordell
Copy link
Owner

nlordell commented Jan 3, 2023

They were stabilized in Rust 1.66.

@nlordell nlordell changed the title Implement {checked,overflowing,saturating,wrapping}_{add,sub}_{signed,unsigned} methods. Implement *_{add,sub}_{signed,unsigned} methods. Jan 3, 2023
@nlordell nlordell added the good first issue Good for newcomers label Aug 29, 2023
@NCGThompson
Copy link
Contributor

Is there any reason (e.g. licensing incompatibility) to not just copy + paste the integer implementation macros from the core library? That seems to be the best option considering the goal is a common interface with the native integers. All of theses functions are derived from intrinsics already implemented.

@nlordell
Copy link
Owner Author

Is there any reason (e.g. licensing incompatibility) to not just copy + paste the integer implementation macros from the core library?

Would you copy the whole integer implementation macros? That's a nice idea and will experiment and see if it "just works" without modifications.

@NCGThompson
Copy link
Contributor

see if it "just works" without modifications.

It won't completely. At least not while strictly using stable features. I don't think we will lose much my deleting the unstable stuff though. I'll get to it.

nlordell pushed a commit that referenced this issue Oct 25, 2023
This branch implements methods analogous to those of the stable feature mixed_integer_ops.

Closes #24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants