Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse streams incrementally. #40

Merged
merged 11 commits into from
Mar 24, 2015
Merged

Parse streams incrementally. #40

merged 11 commits into from
Mar 24, 2015

Conversation

aburgh
Copy link
Contributor

@aburgh aburgh commented Mar 1, 2015

I did not update src/json.hpp because I get different indentation results than the existing version.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8774628 on aburgh:incremental into 5526de1 on nlohmann:master.

@nlohmann
Copy link
Owner

nlohmann commented Mar 1, 2015

Thanks a lot! I'll check this when I'm back from holidays.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 396f64a on aburgh:incremental into 5526de1 on nlohmann:master.

nlohmann added a commit that referenced this pull request Mar 24, 2015
Parse streams incrementally.
@nlohmann nlohmann merged commit 50e06a7 into nlohmann:master Mar 24, 2015
nlohmann added a commit that referenced this pull request Mar 24, 2015
@nlohmann
Copy link
Owner

Thanks a lot!

@aburgh
Copy link
Contributor Author

aburgh commented Mar 24, 2015

Hi Niels,

Glad you found it worthwhile. Not to be too narcissistic, but since you are giving credit in the Readme can you put my name on it? (Unless I am misunderstanding Joshua Randall's contributions.)

Regards,

Aaron

On Mar 24, 2015, at 1:13 PM, Niels [email protected] wrote:

Thanks a lot!


Reply to this email directly or view it on GitHub #40 (comment).

@nlohmann
Copy link
Owner

Hi @aburgh,

I am so sorry! I'll update the README in a second. Again, thanks for the contribution! I'll also check the pull request #41 soon.

All the best
Niels

@aburgh
Copy link
Contributor Author

aburgh commented Mar 24, 2015

No worries, thanks. And thanks again for the project. I'm still getting up to speed on C++, so this was educational. Your project also inspired me to try to adapt it for handling OS X plist files, which are similar to JSON, but have a date and data type, and can be serialized to/from XML and a proprietary binary format.

Cheers,

Aaron

On Mar 24, 2015, at 1:52 PM, Niels [email protected] wrote:

Hi @aburgh https://github.com/aburgh,

I am so sorry! I'll update the README in a second. Again, thanks for the contribution! I'll also check the pull request #41 #41 soon.

All the best
Niels


Reply to this email directly or view it on GitHub #40 (comment).

@aburgh aburgh deleted the incremental branch May 10, 2015 21:47
GerHobbelt pushed a commit to GerHobbelt/nlohmann-json that referenced this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants