-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve unit testing (Part 2) #3385
Draft
falbrechtskirchinger
wants to merge
15
commits into
nlohmann:develop
Choose a base branch
from
falbrechtskirchinger:topic/test-improvements-part2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Improve unit testing (Part 2) #3385
falbrechtskirchinger
wants to merge
15
commits into
nlohmann:develop
from
falbrechtskirchinger:topic/test-improvements-part2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falbrechtskirchinger
force-pushed
the
topic/test-improvements-part2
branch
4 times, most recently
from
March 10, 2022 17:31
1a35528
to
f4d0546
Compare
falbrechtskirchinger
force-pushed
the
topic/test-improvements-part2
branch
from
May 9, 2022 18:07
f4d0546
to
69a2784
Compare
falbrechtskirchinger
changed the title
Improve unit testing (Part 2)
Improve unit testing (Part 2) and fuzz testing
May 9, 2022
Note to self: Add ABI string from #3590 to Edit: Done. |
falbrechtskirchinger
force-pushed
the
topic/test-improvements-part2
branch
5 times, most recently
from
August 1, 2022 11:09
cd146ae
to
bd05c62
Compare
This starts to become a very large PR. Please consider breaking it into smaller pieces, such as the whole fuzzer part. |
falbrechtskirchinger
force-pushed
the
topic/test-improvements-part2
branch
from
August 1, 2022 11:52
bd05c62
to
b3a29f5
Compare
Yes. I'm just using this for CI. Locally I already have a separate branch for the fuzzing stuff. |
falbrechtskirchinger
force-pushed
the
topic/test-improvements-part2
branch
from
August 1, 2022 12:18
b3a29f5
to
3e30e1f
Compare
falbrechtskirchinger
changed the title
Improve unit testing (Part 2) and fuzz testing
Improve unit testing (Part 2)
Aug 1, 2022
falbrechtskirchinger
force-pushed
the
topic/test-improvements-part2
branch
3 times, most recently
from
August 2, 2022 10:46
d927dfc
to
89211f0
Compare
Add and use the following CMake function: json_test_add_standard_keyphrases( PHRASES <args>... CXX_STANDARDS <args>...) Create a mapping between C++ standard versions and key phrases. json_test_add_test_for() will search for these key phrases and build tests for associated C++ standard versions.
Use "logical" ordering for use with ordered_json.
Add a target to print JSON meta for all tested C++ standard versions.
falbrechtskirchinger
force-pushed
the
topic/test-improvements-part2
branch
from
August 3, 2022 20:36
8a27a68
to
dbf568a
Compare
falbrechtskirchinger
force-pushed
the
topic/test-improvements-part2
branch
from
August 3, 2022 20:41
dbf568a
to
35f6a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of the unit test improvements.
The original plan of adding build information output has been scrapped after the code had ballooned into a 4000 line monstrosity.
Instead, this PR addresses some issues that were discussed (remove magic keywords from the unit tests) and adds a very minimal version of what the build information output would have provided by extending JSON meta and printing that at the start of each unit test or via the
print_meta
target.For example, most CI targets will now print the following for each enabled C++ standard:
To Do
meta()
changes.