-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add travis task : compile and test under C++17 #2241
Conversation
@@ -218,6 +218,17 @@ matrix: | |||
sources: ['ubuntu-toolchain-r-test'] | |||
packages: ['g++-9', 'ninja-build'] | |||
|
|||
- os: linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a test case above that sets CXXFLAGS=-std=c++2a
. Maybe this can be reused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, It seems that CXXFLAGS=-std=c++1z
didn't work under c++17.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reopening. |
At the same time, I think we should update Ubuntu distribution in .travis.yml, because |
As long as they are supported by Travis, I am fine with the working setup. I am afraid that the CI breaks if we are moving to a newer version. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
From #2213, we could know that
JSON_HAS_CPP_17
is false in all travis jobs.Thus, we should add a task to compile and test under CXX17.