-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use external test data #2081
Use external test data #2081
Conversation
…om/nlohmann/json into external_test_data
On a clean repo,
|
I am currently moving functionality from the plain Some more info on this: The original Makefile was written in times when the project did not use CMake. Right now, I hope that I am the only one relying on the Makefile, and I keep changing it for my only needs, sometimes hardcoding paths on my machine into it. Once this PR is merged, I would like to continue moving more functionality into CMake and thereby streamlining the whole release process which is currently a large Python project... |
Also related: #1251 |
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
Awesome! Thanks! |
This has the downside that tests will now fail in Linux distribution build environments that have no internet access. |
Is this a thing? I mean: having the library, having no internet connection, yet still want to execute the tests? |
I had to disable the tests for https://build.opensuse.org/request/show/856756 which is not nice but also not too serious. https://build.opensuse.org/package/rdiff/home:Mailaender:branches:devel:libraries:c_c++/nlohmann_json?linkrev=base&rev=2 is my try to disable the data download modules, but it seems they don't disable the tests that depend on it, but that may more be some kind of ctest problem. |
This PR removes the test data from this repository and downloads them from an external repository.
Closes #96
Closes #482
Closes #556
Closes #567
Closes #620
Closes #732
Closes #1066
Closes #1184
Closes #1185
Closes #1235
Closes #1497
Closes #1572
Closes #1790