appveyor.yml: Compile and test with latest version for __cplusplus ma… #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
force-pushed
the
add-zc-flag-for-msvc
branch
from
7553b08 to
d613f09
Compare
|
@nlohmann Ready, I've included your hedley update already. |
|
I had made a test and it was ok. I think this can be merged. |
|
@nlohmann Can we merge this? |
|
Could you please rebase to the latest develop branch? |
…cro on MSVC According to [1] the C++ macro __cplusplus has always the value 199711L even if you enable later version of C++ support via /std. Use one job with /Zc:__cplusplus defined so that we know that it compiles. [1]: https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=vs-2019
|
@nlohmann Done. |
t-b
force-pushed
the
add-zc-flag-for-msvc
branch
from
9ee765a to
5607dfb
Compare
|
Thanks! |
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cro on MSVC
According to 1 the C++ macro __cplusplus has always the value 199711L
even if you enable later version of C++ support via /std.
Use one job with /Zc:__cplusplus defined so that we know that it
compiles.
I can't reopen #1810.
Close #1695.