Unordered map json #165
Closed
Unordered map json #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 30, 2015 11:12
NOTE: This does NOT compile due to unordered_map needing to have an instance in the CompatibleObjectType CTOR for the basic_json object, and basic_json being an incomplete type at that time. For assistance request only.
the unordered_map template cannot be instanced with an incomplete type so this patch replaces all places where this is made necessary with alternative though equivilent types.
|
Looks like this doesn't build on MSVC... Perhaps I have to see if I can mess with a few other things in order to get it working. It might take a while for me to spin a VM, but I'll push a fix ASAP. |
Key_compare is implemented in the std::unordered_map in MSVC, so the result is the initial attempt to use SFINAE to select 1 or the other wasn't effective. This patch makes the 'default' case implement the std::map case so that key_compare isn't used for SFINAE testing.
|
I seem to have managed to cause the same issue you see in #144 |
|
As mentioned in #144, I checked master out directly, and reproduce this same ambigious conversion issue on origin/master! It seems that there is a problem running one of the tests (CHECK(*p2 == value.get<test_type>());, due to os << test_type(json::object_t); being ambigious. I'm going to open a new bug for this one. |
This was referenced Dec 30, 2015
|
The current PR is #209. I close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for unordered map in the json object. See #164 for the bug report and description of the solution.