Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dump to alternative string type, as defined in basic_json template #1006

Merged
merged 5 commits into from
Mar 12, 2018
Merged

dump to alternative string type, as defined in basic_json template #1006

merged 5 commits into from
Mar 12, 2018

Conversation

agrianius
Copy link
Contributor

An alternative string implementation can be defined in basic_json template. These changes allow json::dump to work with the alternative string type.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 392c033 on agrianius:dump-template into 6151dfa on nlohmann:develop.

nlohmann
nlohmann approved these changes Mar 12, 2018
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Mar 12, 2018
@nlohmann nlohmann added this to the Release 3.1.2 milestone Mar 12, 2018
@nlohmann nlohmann merged commit 0cab3b2 into nlohmann:develop Mar 12, 2018
@nlohmann
Copy link
Owner

Thanks a lot!

nlohmann added a commit that referenced this pull request Mar 12, 2018
@nlohmann
📝 thanks for #1006
b56ac86
nlohmann added a commit that referenced this pull request Mar 12, 2018
@nlohmann
♻️ adjusting lexer/parser in symmetry to #1006
8557151
@nlohmann nlohmann mentioned this pull request Mar 12, 2018
Merged
@dota17 dota17 mentioned this pull request Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
None yet
Projects
None yet
Milestone
Release 3.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@agrianius @coveralls @nlohmann