-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check "Parsing JSON is a Minefield" #344
Comments
Todo:
|
Found 6 errors when parsing the "yes" cases:
|
For input files with less than 5 bytes, the parser had a bug so that refilling the input buffer led to erasing it.
The UTF-16 test case (nst_json_testsuite/test_parsing/y_string_utf16.json) is the only missing failing test case. UTF-16 is not supported by this library. The README file should be adjusted accordingly. |
From the "n" test cases, there are the following errors: Unclear/to be checked:
Overflow due to too deep nesting:
|
Merged fixes to develop branch. Scheduled for 2.0.7 release. |
@nlohmann I've posted a PR on the nst test suite using a more-up-to-date version, see nst/JSONTestSuite#98. |
http://seriot.ch/parsing_json.html describes a lot of potential issues. We should have a look whether the library is affected.
The text was updated successfully, but these errors were encountered: