generated from nl-design-system/example
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: add community Contact Timeline and Process Steps tokens of denhaag #838
Open
jeffreylauwers
wants to merge
6
commits into
main
Choose a base branch
from
style/add-community-contact-timeline-and-process-steps-tokens-den-haag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
style: add community Contact Timeline and Process Steps tokens of denhaag #838
jeffreylauwers
wants to merge
6
commits into
main
from
style/add-community-contact-timeline-and-process-steps-tokens-den-haag
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeffreylauwers
commented
Nov 28, 2024
•
edited
Loading
edited
- This PR will provide the necessary tokens for the Contact Timeline component of Den Haag.
- Because the Contact Timeline component also used tokens of the Process Steps component I added those as well.
- We also update the value of common tokens 'container' and 'line' to a slightly darker gray.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jeffreylauwers
changed the title
style: add community Contact Timeline and Process Steps tokens of den…
style: add community Contact Timeline and Process Steps tokens of denhaag
Nov 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
=======================================
Coverage 89.48% 89.48%
=======================================
Files 19 19
Lines 1332 1332
Branches 178 125 -53
=======================================
Hits 1192 1192
Misses 140 140 ☔ View full report in Codecov by Sentry. |
Yolijn
approved these changes
Dec 5, 2024
Yolijn
previously approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.