Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Meerdere ReadME's kunnen inladen in documentatie pagina #1010

Closed
Rozerinay opened this issue Dec 13, 2024 · 2 comments · Fixed by #1070
Closed

FEAT: Meerdere ReadME's kunnen inladen in documentatie pagina #1010

Rozerinay opened this issue Dec 13, 2024 · 2 comments · Fixed by #1070
Assignees

Comments

@Rozerinay
Copy link
Contributor

Rozerinay commented Dec 13, 2024

Deze is afhankelijk van: #1009.

Context
Op dit moment kunnen wij nog geen README files per component inladen. We hebben nu de README van Utrecht gekopieerd en geplakt in onze eigen .md files.

Oplossingsrichting
Verander voor 1 component de README zodat we weten hoe wij Utrecht README per component kunnen inladen.

@Rozerinay Rozerinay converted this from a draft issue Dec 13, 2024
@Rerbun Rerbun mentioned this issue Dec 24, 2024
19 tasks
@Rerbun Rerbun self-assigned this Dec 24, 2024
@Rerbun Rerbun moved this from Todo to In Progress in Community Sprint - Rijkshuisstijl Dec 24, 2024
@Rerbun
Copy link
Contributor

Rerbun commented Dec 31, 2024

Voor deze issue ga ik ook gelijk een parameter toevoegen waarmee je aan kan geven waar een component vandaan komt

@Rerbun Rerbun closed this as completed in 45148db Jan 3, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Community Sprint - Rijkshuisstijl Jan 3, 2025
This was referenced Jan 8, 2025
This was referenced Jan 15, 2025
WebBeest pushed a commit that referenced this issue Jan 27, 2025
…ade small fixes to make everything as consistent as possible (#1070)

closes #981 
closes #1010 
also made first steps to use @utrecht/components, but only in storybook
for now (#1009)

- There are a lot of // TODO comments because in a lot of cases the
documentation is not structurized correctly in @utrecht/components.
Wherever it was in the right structure I used the Utrecht documentation
as much as possible (although sometimes they were very lacking in
content, in which cases I skipped them as well)
- I added functionality to packages/storybook/config/preview.tsx to
render links and componentOrigin text that can be added using the
github, figma, nldesignsystem and componentOrigin parameters in
storybook respectively.
- Here is an example of a storybook page where the links are filled with
parameters and the documentation is coming from @utrecht/components:
[Radio
button](https://rijkshuisstijl-community-git-chore-utre-1cc52e-nl-design-system.vercel.app/?path=/docs/rhc-radio--docs)

---------

Co-authored-by: Ruben Smit <[email protected]>
WebBeest pushed a commit that referenced this issue Jan 27, 2025
…ade small fixes to make everything as consistent as possible (#1070)

closes #981 
closes #1010 
also made first steps to use @utrecht/components, but only in storybook
for now (#1009)

- There are a lot of // TODO comments because in a lot of cases the
documentation is not structurized correctly in @utrecht/components.
Wherever it was in the right structure I used the Utrecht documentation
as much as possible (although sometimes they were very lacking in
content, in which cases I skipped them as well)
- I added functionality to packages/storybook/config/preview.tsx to
render links and componentOrigin text that can be added using the
github, figma, nldesignsystem and componentOrigin parameters in
storybook respectively.
- Here is an example of a storybook page where the links are filled with
parameters and the documentation is coming from @utrecht/components:
[Radio
button](https://rijkshuisstijl-community-git-chore-utre-1cc52e-nl-design-system.vercel.app/?path=/docs/rhc-radio--docs)

---------

Co-authored-by: Ruben Smit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants