Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Fix/responsive openforms pages #25

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

YourivHDenHaag
Copy link

Fixes for issue #9

  • Updated @Gemeente-DenHaag versions
  • Use buttongroup instead of toolbar list
  • Added the grid as defined in the designs

@YourivHDenHaag YourivHDenHaag requested a review from Yolijn August 9, 2022 14:05
@YourivHDenHaag YourivHDenHaag mentioned this pull request Aug 9, 2022
4 tasks
@@ -21,7 +21,7 @@ const ButtonsToolbar = ({literals, canSubmitStep, canSubmitForm, loginRequired,
onClick={onNavigatePrevPage}
><Literal name="previousText"/></Button>
</ToolbarList>*/}
<ToolbarList>
<div className="denhaag-button-group denhaag-button-group--multiple">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm zo te zien hebben we dus ook zelf een custom ToolbarList geïmplementeerd, goed om even te onthouden bij het compleet krijgen van open-forms-sdk zonder fork :)

Copy link
Member

@Yolijn Yolijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for the POC, however I think we'll need to figure out a way to add the _loayout.scss as a global override for open forms or as css for a classname we'll add to open-forms.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants