Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: align editorconfig and prettier #689

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

matijs
Copy link
Member

@matijs matijs commented Jun 28, 2024

Switch to a default .editorconfig configuration with an override for .md and .mdx files instead of having to configure every file type explicitly (.cjs and .mjs were not included previously)

Rename .prettierrc.json to prettier.config.cjs and use a default configuration changing only the settings that differ from Prettier's defaults. Add overrides for YAML and CSS files. This configuration had the fewest violations that needed fixing.

Now all current as well as future file types have a preferred formatting configuration.

Fix formatting violations in .mdx and .mjs files.

Switch to a default .editorconfig configuration with an override for
`.md` and `.mdx` files instead of having to configure every file type
explicitly (`.cjs` and `.mjs` were not included previously)

Rename `.prettierrc.json` to `prettier.config.cjs` and use a default
configuration changing only the settings that differ from Prettier's
defaults. Add overrides for YAML and CSS files. This configuration
had the fewest violations that needed fixing.

Now all current as well as future file types have a preferred formatting
configuration.

Fix formatting violations in `.mdx` and `.mjs` files.
@matijs matijs requested a review from Robbert June 28, 2024 07:25
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 7:25am

@Robbert Robbert merged commit 0702fef into main Jun 28, 2024
8 checks passed
@Robbert Robbert deleted the build/editor-config-prettier branch June 28, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants