Add external links to the 'docs' directory #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-learning-lab[bot]](https://avatars.githubusercontent.com/in/10572?s=60&v=4){kind=small}
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.4 to 1.10.8. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.4...v1.10.8) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.3 to 2.2.0. - [Release notes](https://github.com/rubyzip/rubyzip/releases) - [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md) - [Commits](rubyzip/rubyzip@v1.2.3...v2.2.0) Signed-off-by: dependabot[bot] <[email protected]>
| - checkout | ||
|
|
||
| - run: | ||
| name: build dependencies |
There was a problem hiding this comment.
Suggested change
| name: build dependencies | |
| command: bundle exec htmlproofer ./_site --check-html |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of links to our code base, we should add a unit test as one of our CircleCI jobs that run whenever it builds.
Let's add a test using HTMLProofer to test for any broken links, images, or HTML. By adding this to our
testlinksunit test, HTMLProofer will test our code before it gets merged.CircleCI allows us to configure multiple jobs using a feature called Workflows. Since we're interested in performing two jobs (a build, and a test for links), we'll use Workflows.
I've already added some things necessary for HTMLProofer test to run, and implemented the use of the Workflows feature. Next, replace the placeholder text with the following:
bundle exec htmlproofer ./_site --check-htmlStep 9: Add an HTMLProofer unit test
Let's make sure all links are valid by adding a link checker unit test.
⌨️ Activity: Check for broken links using CircleCI
REPLACE-ME-WITH-SCRIPTplaceholder text withbundle exec htmlproofer ./_site --check-html. You can do this by editing the file from the Files changed tab, or by scrolling down and accepting the suggested change.I'll respond below with your next step.