Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade spectron #510

Closed
wants to merge 1 commit into from
Closed

Conversation

ekoeryanto
Copy link

fixes #467

@ekoeryanto
Copy link
Author

But, what about make spectron and electron as peers?

@nklayman
Copy link
Owner

@ekoeryanto spectron cannot be a peer dep as it is imported by the testWithSpectron feature. I plan on releasing v2 of this plugin with upgrades to all major deps, including spectron.

@ekoeryanto
Copy link
Author

@nklayman I think we should use correct spectron version based on choosen electron version.

Electron Version Spectron Version
~1.0.0 ~3.0.0
~1.1.0 ~3.1.0
~1.2.0 ~3.2.0
~1.3.0 ~3.3.0
~1.4.0 ~3.4.0
~1.5.0 ~3.5.0
~1.6.0 ~3.6.0
~1.7.0 ~3.7.0
~1.8.0 ~3.8.0
^2.0.0 ^4.0.0
^3.0.0 ^5.0.0
^4.0.0 ^6.0.0
^5.0.0 ^7.0.0
^6.0.0 ^8.0.0

@nklayman
Copy link
Owner

I can't do that though as it is defined in the package.json which shouldn't be changed.

@nklayman
Copy link
Owner

Closing as v2.0 beta allows the user to choose their version of spectron.

@nklayman nklayman closed this Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling testWithSpectron() opens infinite windows
2 participants