added a safety fix for when save ends up as a no-operation #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that the revision number does not go up, and this ToDictionary call fails.
@MrHinsh Do you think we need a "backwards do not enable" flag in config so that we don't enable this fix by default? Since we are not getting alot of reports of this happening either people does not know or I have running into a freak case. In my case there was alot of revisions popping up in the list that was representing a link change, aka parent removed or similar
The fault does not break the run, you only spots that some revisions are missing, and that there are no reflectedworkitem written to the custom field and no migration comment in the history