Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating NJOY2016 to 2016.74 #185

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Updating NJOY2016 to 2016.74 #185

merged 5 commits into from
Jan 22, 2024

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Jan 16, 2024 •
edited
Loading

This integrates changes for NJOY2016.73 and 2016.74 (there is no NJOY21 using 2016.73 directly).

The following tests were updated:

  • test 20 for the LRF=7 update for the Euler-Mascheroni update in 2016.74
  • updated tests 67 and 70 (thermal scattering plots) and added tests 80 and 81

@whaeck whaeck marked this pull request as draft January 16, 2024 20:23
@whaeck whaeck marked this pull request as ready for review January 16, 2024 21:09
@whaeck whaeck requested a review from nathangibson14 January 16, 2024 21:09
@whaeck whaeck marked this pull request as draft January 17, 2024 16:28
@whaeck whaeck closed this Jan 17, 2024
@whaeck
Copy link
Member Author

whaeck commented Jan 17, 2024

There seems to be an issue with the CI so I'm closed this before opening it again to see if it fixes the issue.

@whaeck whaeck reopened this Jan 17, 2024
@whaeck whaeck marked this pull request as ready for review January 17, 2024 16:30
@whaeck whaeck merged commit 3b2651f into master Jan 22, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathangibson14 nathangibson14 Awaiting requested review from nathangibson14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@whaeck