Update/tools dependency #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes disco as a dependency from ENDFtk and replaces it with a disco rewrite in the tools library. This update solves the issue where 2.000+0 gets read as 1.999999999.
The interface has undergone minimal changes so the impact of this update is extremely small.
As a side note: the tools library updates that introduced disco are still under review so the dependency is just pointing to a specific commit of the feature/python-views in tools. I will not merge this until we have tagged a tools release and point to that instead. That will just change the dependency files so we can already proceed with review.