Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jshs #2

Merged
merged 368 commits into from
May 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
368 commits
Select commit Hold shift + click to select a range
36ea881
Merge branch 'dev' of https://github.com/nightscout/cgm-remote-monito…
PieterGit Oct 22, 2018
16248a1
Leap forward... remove npm 5.x support, upgrade packages and also tes…
PieterGit Oct 22, 2018
d86b60d
mongodb. add newNewUrlParser: true to mongo options
PieterGit Oct 22, 2018
81f5a5f
travis. always build latest lts and latest stable
PieterGit Oct 22, 2018
969ac25
make travis more clear to build for node js 8 and 10
PieterGit Oct 22, 2018
65660c5
Merge pull request #4004 from jpcunningh/wip/devicestatus_insert_err
PieterGit Oct 23, 2018
ee8ed70
Merge pull request #3954 from jpcunningh/cgm_voltage_b_fix
PieterGit Oct 23, 2018
65372ab
Merge pull request #3953 from PieterGit/201809_npm_node_update
PieterGit Oct 23, 2018
7f7fe9c
add cgm sensor stop
Oct 24, 2018
de86d77
Merge pull request #12 from nightscout/dev
unsoluble Oct 24, 2018
18497f2
Update alexa-plugin.md
unsoluble Oct 24, 2018
9b238df
Merge pull request #4025 from unsoluble/alexa-docs-tweak
PieterGit Oct 24, 2018
aca7565
Merge pull request #2 from nightscout/dev
DigitalDan1 Oct 28, 2018
e930b1d
fix daylight saving bug in profile editor
DigitalDan1 Oct 28, 2018
834d5f9
Merge pull request #4029 from DigitalDan1/dev
PieterGit Oct 28, 2018
ae9e5d7
Update Russian
apanasef Oct 29, 2018
0e306b8
Fixes day to day rendering crashing if data contains a Profile Switch…
sulkaharo Oct 29, 2018
a665aca
Previous fix actually appended a blank note, this checks if the data …
sulkaharo Oct 30, 2018
7e311c5
Merge pull request #4031 from nightscout/wip/fix-empty-profile
sulkaharo Oct 30, 2018
e3a4e96
Merge pull request #14 from nightscout/dev
unsoluble Nov 1, 2018
36ac89a
Merge pull request #4030 from apanasef/patch-23
PieterGit Nov 3, 2018
e180f8f
redirect HTTP to HTTPS unless explicitly instructed not to do this re…
Nov 4, 2018
372efca
add support for HSTS and other security related HTTP headers via helmet
Nov 5, 2018
24b093f
fix for https://github.com/nightscout/cgm-remote-monitor/issues/4050 …
PieterGit Nov 8, 2018
c29f7a4
Merge pull request #4052 from PieterGit/201811_healthline
PieterGit Nov 8, 2018
da499a4
Added new phrase to language.js
Nov 9, 2018
9ebc110
Missed initializing one.
Nov 9, 2018
96de78a
Grammar and typo updates. External links included where necessary.
Nov 9, 2018
1410c68
Merge pull request #4060 from jpcunningh/add-sensor-stop
PieterGit Nov 16, 2018
93be1a6
Merge pull request #3 from nightscout/dev
DigitalDan1 Nov 16, 2018
4271a81
Fix re-loading bug in profile editor and ensure changes made by the u…
DigitalDan1 Nov 16, 2018
86576fa
Merge pull request #4062 from rarneson/contributing-docs-updates
PieterGit Nov 16, 2018
986e2bc
add contributor table and rerun doctoc
PieterGit Nov 16, 2018
779352d
make links to github profile
PieterGit Nov 16, 2018
04e9320
last fixes to CONTRIBUTING.md for tonight
PieterGit Nov 16, 2018
46dba29
fix toc
PieterGit Nov 16, 2018
5109fb0
Merge pull request #4075 from PieterGit/201811_contributors
PieterGit Nov 16, 2018
4f9ab0b
npm update and manual upgrade to newer versions
PieterGit Nov 16, 2018
b98084c
Add jpcunningh to some plugins in CONTRIBUTING
Nov 18, 2018
035fe20
Merge pull request #4077 from jpcunningh/add-to-contributors
PieterGit Nov 18, 2018
e10944d
Reduce the amount of Profile Switch treatments being loaded, to fix #…
sulkaharo Nov 19, 2018
4857d42
After discussing with Milos, actually only guarantee 1 duration 0 pro…
sulkaharo Nov 19, 2018
a98ed22
Wrong keyword in how the limit is applied
sulkaharo Nov 19, 2018
d375386
Merge branch 'dev' of https://github.com/nightscout/cgm-remote-monito…
PieterGit Nov 20, 2018
0e2ae00
npm update and remove mqtt
PieterGit Nov 20, 2018
70aa225
remove sgvdata
PieterGit Nov 20, 2018
a0f0ef4
Fix re-loading bug in profile editor and ensure changes made by the u…
DigitalDan1 Nov 16, 2018
a13d8ff
Add treatments delete id debug.
Nov 21, 2018
3d6fd35
Fix devicestatus ObjectID usage.
Nov 21, 2018
630114e
Use new objId in api call
Nov 21, 2018
abe8554
Make ObjectID initialization consistent
Nov 21, 2018
721b38d
Fix syntax errors in websocket.js
Nov 21, 2018
cf7b40e
Merge pull request #4088 from jpcunningh/fix-devicestatus-and-treatme…
PieterGit Nov 21, 2018
5787482
Merge pull request #4044 from jweismann/dev
PieterGit Nov 21, 2018
266ab63
Merge branch 'dev' of https://github.com/nightscout/cgm-remote-monito…
PieterGit Nov 21, 2018
e644f64
Merge pull request #7 from nightscout/dev
herzogmedia Nov 21, 2018
292ed12
update fontello
PieterGit Nov 21, 2018
c0f43b3
minor german language changes
herzogmedia Nov 21, 2018
3946715
Adding me to list of translators
herzogmedia Nov 21, 2018
ec6fe2c
improve helmet use
PieterGit Nov 21, 2018
9ab0f3a
add default security settings and test
PieterGit Nov 21, 2018
4575a65
add default for hsts extendsettings
PieterGit Nov 21, 2018
f1108e0
fix app.json
PieterGit Nov 21, 2018
90f87e0
redirect by default
PieterGit Nov 21, 2018
5d4029a
test
PieterGit Nov 21, 2018
246ee3c
test csp
PieterGit Nov 21, 2018
5110bc4
allow 'unsafe-inline' for stylesSrc and scriptSrc
PieterGit Nov 21, 2018
d95bef4
Turkish language support added
XP2025A Nov 25, 2018
2b958c9
npm update, disable Content Security Policy headers for now. Current…
PieterGit Nov 28, 2018
5edf232
fix settings.test.js
PieterGit Nov 28, 2018
6fa2faf
Merge pull request #4094 from diabetlum/dev
PieterGit Nov 28, 2018
f47c6c3
Merge pull request #4091 from PieterGit/201811_update
PieterGit Nov 28, 2018
f3bc3a5
Merge branch 'dev' into 181121-minorLgGER
herzogmedia Nov 28, 2018
5ac35de
fix INSECURE_USE_HTTP
PieterGit Nov 28, 2018
48f8ecb
Merge pull request #4104 from PieterGit/201811_update
PieterGit Nov 28, 2018
809bd7a
Some correction
XP2025A Nov 30, 2018
ec2e3f9
Some corrections
XP2025A Dec 1, 2018
d05d3a3
Some corrections-1
XP2025A Dec 1, 2018
6144d18
Some corrections-2
XP2025A Dec 1, 2018
4c66b40
Some corrections-3
XP2025A Dec 1, 2018
dab217f
clean Turkish language support
XP2025A Dec 1, 2018
433316b
Merge pull request #4107 from diabetlum/dev
PieterGit Dec 1, 2018
02c3db3
Merge pull request #4108 from diabetlum/dev
PieterGit Dec 1, 2018
3735840
Fix identation
Dec 1, 2018
69b098f
Initial weektoweek
Nov 29, 2018
021a921
More updates for weektoweek
Dec 1, 2018
af8a1c6
Add weektoweek report to index
Dec 1, 2018
4877a9c
Fix syntax error
Dec 1, 2018
5c65790
Fix syntax error
Dec 1, 2018
f70f0ed
Fix spelling for localeData
Dec 1, 2018
8e573b7
Fix initialization of weekstoshow array
Dec 1, 2018
e41f8f8
Initialize new week
Dec 1, 2018
f6bfec0
Fix call to prepareHtml
Dec 1, 2018
9713783
Make new sgv array for each week
Dec 2, 2018
d157313
Fix reference into datastorage array
Dec 2, 2018
88cd9aa
Increment currDay as required
Dec 2, 2018
6aa90a5
error correction rising/falling
Dec 2, 2018
670f172
Add weektoweek debug logs
Dec 2, 2018
0e54270
clean Turkish language support
XP2025A Dec 2, 2018
f74eeaf
Fix syntax error
Dec 2, 2018
577726b
Fixed index error
Dec 2, 2018
72bc14c
Handle sort order differences
Dec 2, 2018
6605535
Sort week before prepareHtml
Dec 2, 2018
75c05f9
Fix syntax error
Dec 2, 2018
10caa0d
Merge pull request #15 from nightscout/dev
unsoluble Dec 3, 2018
b38bea3
Test fix for week partition
Dec 3, 2018
c12ec3b
Fix first day of week getting squashed
Dec 3, 2018
b6fd5f7
Fix it for real this time
Dec 3, 2018
957d907
Update app.json
unsoluble-test Dec 3, 2018
12e80ac
Fix missing comma
unsoluble-test Dec 3, 2018
6a0e5d9
Adds back the support for loading Entries with CSV and TEXT formats (…
sulkaharo Dec 3, 2018
29a18fc
Merge pull request #4115 from diabetlum/dev
MilosKozak Dec 4, 2018
792734a
Merge pull request #4092 from herzogmedia/181121-minorLgGER
MilosKozak Dec 4, 2018
26d1de7
Initial Japanese Additions
LuminaryXion Dec 4, 2018
3c20084
Don't move to next week if current week is empty
Dec 4, 2018
34990da
Fix syntax error
Dec 4, 2018
14fa9ef
Color by day and week report specific size and scale
Dec 5, 2018
3af52f9
Comment out some debug
Dec 5, 2018
49bcfcf
style format update
Dec 5, 2018
6825eda
Use from and to dates to set week span for week2week
Dec 5, 2018
594bae9
Fix newest on top start point
Dec 5, 2018
9ecdb89
Fix newest on top
Dec 5, 2018
06d7e4e
Don't render week to week if not selected
Dec 5, 2018
0f2bbd5
Merge pull request #4119 from LuminaryXion/patch-2
PieterGit Dec 5, 2018
d31099d
Add unit test for weektoweek report
Dec 6, 2018
cd6fb2e
Remove weektoweek logging code
Dec 6, 2018
759dd40
Add clean treatments admin tool.
Nov 21, 2018
cd459fa
Fix clean treatments status html id name
Nov 21, 2018
b429eef
Return status to treatments delete by query
Nov 21, 2018
9123de4
Add clean entries db admin tool
Nov 21, 2018
15cbfea
Correct delete query fields for entries db
Nov 21, 2018
ff04394
Make devicestatus delete consistent with entries
Nov 21, 2018
769b66a
cleanup devicestatus delete
Nov 21, 2018
44baf2e
Add isId to api/devicestatus
Nov 21, 2018
c6e2056
Set query options correctly for devicestatus
Nov 21, 2018
098f372
Use dateString for devicestatus date field
Nov 21, 2018
4f10e03
Fix devicestatus default date field
Nov 21, 2018
71efc5e
Fix devicestatus delete query handling
Nov 21, 2018
41d9d8a
No 'model' concept for devicestatus
Nov 21, 2018
d1b5c56
initialize query find by id correctly for devicestatus delete
Nov 21, 2018
af3e01a
Match devicestatus api indention
Nov 21, 2018
69b73df
Make treatments delete match devicestatus
Nov 21, 2018
ada17c8
Remove old treatments id api path
Nov 21, 2018
50952de
Add entries support for delete query
Nov 21, 2018
b448906
Remove unused function.
Nov 22, 2018
7a01c40
Removed unused function.
Nov 22, 2018
1734ec1
Add API updates for new delete options.
Dec 2, 2018
440807e
Reload data when entries or treatments are deleted
Dec 7, 2018
aa90fd5
Fix week 2 week report when not all weekdays are selected
Dec 8, 2018
6aef8ed
Fix weekNum calculation
Dec 8, 2018
bef3b69
Make week2week more resilient to date selections
Dec 8, 2018
30feb86
Fix codacy findings
Dec 8, 2018
ed97169
Remove more unused variables
Dec 8, 2018
9b59845
Add new strings to language.js
Dec 10, 2018
8136633
Prevent deleting entries or treatments more recent than 2 days ago
Dec 10, 2018
d9527d3
Add unit test for removing old devicestatus records
Dec 10, 2018
a34167a
Fix codacy finding
Dec 10, 2018
83bd1a7
Add unit test for cleantreatmentsdb.js
Dec 10, 2018
d3368e5
Add unit test for cleanentriesdb.js
Dec 10, 2018
8e29dc7
Update Makefile
sulkaharo Dec 12, 2018
70e50bf
Update Makefile
sulkaharo Dec 12, 2018
19e7bc3
Add insert, query, delete test for treatments api
Dec 15, 2018
44d9c54
Add insert, query, delete test for entries api
Dec 16, 2018
8921e3a
Add insert, query, delete test for devicestatus api
Dec 16, 2018
2c8aa05
Japanese!
LuminaryXion Dec 18, 2018
5a061c3
More Japanese
LuminaryXion Dec 19, 2018
201aac6
Add support for Node 10. Upgrade to node 8.14.x . Don't start on olde…
PieterGit Dec 24, 2018
89bb3c2
allow node ^10.4.2 || ^8.14.1 || ~8.11.1
PieterGit Dec 24, 2018
87c101a
fix version typo and add missing parts of PR
Dec 26, 2018
06a7133
Additions and improvements for Danish language
janrpn Dec 27, 2018
dd91d05
Merge pull request #16 from nightscout/dev
unsoluble Dec 29, 2018
5acf173
Update bgclock.html
unsoluble-test Dec 29, 2018
82c7678
Pad 24h hours with zero
unsoluble-test Dec 30, 2018
e72ece1
Merge pull request #4160 from janrpn/dev
PieterGit Dec 31, 2018
3355566
Merge branch '201812_node10' of https://github.com/PieterGit/cgm-remo…
PieterGit Dec 31, 2018
f5df521
Merge branch 'weektoweek-report' of https://github.com/jpcunningh/cgm…
PieterGit Dec 31, 2018
e195fcb
Merge branch 'entries-and-treatments-clean-db' of https://github.com/…
PieterGit Dec 31, 2018
ddbbfe2
Merge branch 'wip/fix-rawbg-calculations' of https://github.com/jpcun…
PieterGit Dec 31, 2018
89ce188
PR with several PR's that needs testing
PieterGit Dec 31, 2018
bbb5ca9
Merge branch '201807_python' of https://github.com/PieterGit/cgm-remo…
PieterGit Dec 31, 2018
be512a0
Upgrade to Node 10 for Azure. Upgrade to version Node 8.15.0 for Node…
PieterGit Dec 31, 2018
6a792f7
Merge branch '201812_node10' of https://github.com/PieterGit/cgm-remo…
PieterGit Dec 31, 2018
f61fb94
update code comments on Node versions
PieterGit Jan 1, 2019
e88a417
Merge branch 'api-insert-delete-test' of https://github.com/jpcunning…
PieterGit Jan 1, 2019
5679266
Updated rawbg settings to use a single setting tri-state variable.
Jan 1, 2019
e77e3d8
upgrade share2nightscout-bridge to ~0.2.0-dev-20190102
PieterGit Jan 2, 2019
6a7ffa5
update to released version of share2nightscout-bridge and update webp…
PieterGit Jan 4, 2019
e111b4c
Added Japanese
LuminaryXion Jan 4, 2019
4354e26
Merge branch 'dev' into patch-3
LuminaryXion Jan 4, 2019
896d5e0
add jsdom pinned to 11.11.0 (required for benv unit tests)
PieterGit Jan 4, 2019
8f29632
Make weektoweek use SCALE_Y system setting correctly
Jan 5, 2019
716fd76
Make default scale y initialize correctly
Jan 5, 2019
a2a9248
Cleanup code for initializing weektoweek scale
Jan 5, 2019
2fded60
Merge branch 'weektoweek-report' of https://github.com/jpcunningh/cgm…
PieterGit Jan 5, 2019
9b711de
Merge branch '201901_share2nightscout' of https://github.com/PieterGi…
PieterGit Jan 5, 2019
3bd73d7
Merge branch 'wip/fix-rawbg-calculations' of https://github.com/jpcun…
PieterGit Jan 5, 2019
1dc6829
Merge pull request #4169 from PieterGit/201812_needs_testing
PieterGit Jan 5, 2019
773ebdb
Merge pull request #4184 from LuminaryXion/patch-4
PieterGit Jan 6, 2019
4c74c03
Add mmconnect note to the ENABLE description
unsoluble Jan 7, 2019
1d5adc6
Add MMCONNECT_ vars
unsoluble Jan 7, 2019
8057c42
Update minimed-connect-to-nightscout reference
unsoluble Jan 7, 2019
dc78ca2
Update moment dependency to match dev
unsoluble Jan 7, 2019
6e8db98
Removed advanced entries for clarity
unsoluble Jan 8, 2019
107fdf8
Tweak mLab/Mongo wording
unsoluble Jan 11, 2019
3ec9664
Merge pull request #4147 from LuminaryXion/patch-2
PieterGit Jan 11, 2019
2da377d
Have the UI fully update immediately after new data update. Debounce …
sulkaharo Jan 12, 2019
11c6086
Update --bug-report.md
sulkaharo Jan 15, 2019
fc37fbc
Update README.md
renegadeandy Jan 22, 2019
8caf1bd
Update README.md
renegadeandy Jan 22, 2019
ef96d94
Fixed the spacing.
LuminaryXion Jan 25, 2019
58c9e70
Semiquote
LuminaryXion Jan 25, 2019
42b954e
spacing check.
LuminaryXion Jan 27, 2019
b035643
Spacing Test x2
LuminaryXion Jan 27, 2019
a437543
This should do it!
LuminaryXion Jan 27, 2019
4d38ef4
Merge pull request #4150 from LuminaryXion/patch-3
PieterGit Jan 27, 2019
105ba82
Norwegian language corrections and translations
anderser Jan 27, 2019
7022079
Merge remote-tracking branch 'upstream/dev' into dev
DigitalDan1 Jan 30, 2019
cefa000
Merge branch 'dev' of https://github.com/DigitalDan1/cgm-remote-monit…
DigitalDan1 Jan 30, 2019
8ff5558
Merge pull request #4239 from anderser/dev
PieterGit Feb 2, 2019
8153241
Merge pull request #4225 from renegadeandy/dev
PieterGit Feb 2, 2019
81c38e5
Merge pull request #4074 from DigitalDan1/dev
PieterGit Feb 2, 2019
04ec3ab
make Saving profile translatable
PieterGit Feb 2, 2019
8f29abd
revert minimed-connect version
unsoluble-test Feb 2, 2019
4d4b3e9
two small tweaks
unsoluble-test Feb 2, 2019
3104083
fix readENVTruthy and make INSECURE_USE_HTTP, SECURE_HSTS_HEADER, SEC…
PieterGit Feb 2, 2019
22570d0
Merge pull request #4116 from unsoluble/Heroku-template-tweaks
PieterGit Feb 2, 2019
2260fb4
Merge pull request #4162 from unsoluble/bgclock-24h-fix
PieterGit Feb 2, 2019
0b7fe94
npm update
PieterGit Feb 2, 2019
05d47f8
Merge branch 'dev' of https://github.com/nightscout/cgm-remote-monito…
PieterGit Feb 2, 2019
6432298
add missing env
PieterGit Feb 2, 2019
8098cda
upgrade to minmum of Node 10.15.1
PieterGit Feb 2, 2019
a6b98c3
fix ident and add extra test to env.test.js
PieterGit Feb 2, 2019
9c5a2e4
remove mqtt leftover
PieterGit Feb 2, 2019
cabace2
ie8 is not compatible with Terser, so make that explicit
PieterGit Feb 2, 2019
d97fd97
npm update and integrate terser-webpack-plugin as minimizer
PieterGit Feb 3, 2019
ab54f09
user correct env
PieterGit Feb 3, 2019
125a073
Merge pull request #4253 from PieterGit/201901_profile_save_workaround2
PieterGit Feb 3, 2019
7df3d32
Update IFTTT maker-setup.md docs (#4206)
Dave9111 Feb 3, 2019
48dbb80
Loopalyzer enhanced (#4215)
lixgbg Feb 3, 2019
46b7e67
Maker docs copyedit & cleanup (#4256)
unsoluble Feb 3, 2019
090b4dd
Reimplement Predictions support to Reports (#4254)
PieterGit Feb 4, 2019
4810819
set version to release candidate 1: 0.11.0-rc1-20190205 (#4259)
PieterGit Feb 4, 2019
85e6916
fix contributors (#4260)
PieterGit Feb 5, 2019
3acd7c8
Fix auth button ui & update cache busting for App Cache (#4270)
sulkaharo Feb 7, 2019
0198bcc
Merge branch 'master' into release/0.11
sulkaharo Feb 7, 2019
ee92df2
Merge master to dev (#4273)
sulkaharo Feb 7, 2019
022a082
Merge branch 'release/0.11' of github.com:nightscout/cgm-remote-monit…
sulkaharo Feb 7, 2019
48c0f59
Merge pull request #4272 from nightscout/release/0.11
sulkaharo Feb 7, 2019
dcd9871
Update release version
sulkaharo Feb 7, 2019
dc7ea1b
release 0.11.1 (#4279)
PieterGit Feb 8, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/--bug-report.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
name: "\U0001F41BBug report"
about: Create a report to help us improve things
label: bug

---

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8.11.x
8.x
5 changes: 3 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
language: node_js
os: osx
node_js:
- "10"
- "8"
os:
- osx
before_install:
- if [[ `npm --version` != "5.8.0" ]]; then npm install -g npm@latest; npm --version; fi
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew update; fi
# https://github.com/Homebrew/homebrew-core/issues/26358
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew unlink python; fi
Expand Down
184 changes: 175 additions & 9 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
- [Comments and issues](#comments-and-issues)
- [Co-ordination](#co-ordination)
- [Other Dev Tips](#other-dev-tips)
- [List of Contributors](#list-of-contributors)
- [Core developers, contributing developers, coordinators and documentation writers](#core-developers-contributing-developers-coordinators-and-documentation-writers)
- [Plugin contributors](#plugin-contributors)
- [Translators](#translators)
- [List of all contributors](#list-of-all-contributors)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

Expand Down Expand Up @@ -50,11 +55,11 @@ You can get the dev branch checked out using `git checkout dev`.

## Style Guide

Some simple rules, that will make it easier to maintain our codebase:
Some simple rules that will make it easier to maintain our codebase:

* All indenting should use 2 space where possible (js, css, html, etc)
* A space before function parameters, such as: `function boom (name, callback) { }`, this makes searching for calls easier
* Name your callback functions, such as `boom('the name', function afterBoom ( result ) { }`
* All indenting should use 2 space where possible (js, css, html, etc).
* Include a space before function parameters, such as: `function boom (name, callback) { }`, this makes searching for function calls easier.
* Name your callback functions, such as `boom('the name', function afterBoom ( result ) { }`.
* Don't include author names in the header of your files, if you need to give credit to someone else do it in the commit comment.
* Use single quotes.
* Use the comma first style, for example:
Expand All @@ -71,7 +76,15 @@ If in doubt, format your code with `js-beautify --indent-size 2 --comma-first -

## Create a prototype

<<<<<<< HEAD
Fork cgm-remote-monitor and create a branch.
You can create a branch using `git checkout -b wip/add-my-widget`.
This creates a new branch called `wip/add-my-widget`. The `wip`
stands for work in progress and is a common prefix so that we know
what to expect when reviewing many branches.
=======
Fork cgm-remote-monitor and create a branch. You can create a branch using `git checkout -b wip/add-my-widget`. This creates a new branch called `wip/add-my-widget`. The `wip` stands for work in progress and is a common prefix so that when know what to expect when reviewing many branches.
>>>>>>> master

## Submit a pull request

Expand All @@ -82,6 +95,24 @@ This can be done by checking your code `git commit -avm 'my improvements are her
Now that the commits are available on github, you can click on the compare buttons on your fork to create a pull request. Make sure to select [Nightscout's `dev` branch](https://github.com/nightscout/cgm-remote-monitor/tree/dev).

We assume all new Pull Requests are at least smoke tested by the author and all code in the PR actually works.
<<<<<<< HEAD

Please include a description of what the features do and rationalize why the changes are needed.

If you add any new NPM module dependencies, you have to rationalize why there are needed - we prefer pull requests that reduce dependencies, not add them.

When adding new features that add confugration options, please ensure the `README` document is amended with information on the new configuration.

## Bug fixing

If you've fixed a bug, please consider adding a unit test to the `/tests` folder that reproduces the original bug without the change.
Try to identify the root cause of the issue and fix the issue. Pull requests that simply add null checks to hide issues are unlikely to be accepted.

This can be done by committing your code `git commit -avm 'my
improvements are here'`, and pushing it to the branch you created on your own
fork. This will probably look something like
`git push -u origin wip/add-my-widget`.
=======

Please include a description of what the features do and rationalize why the changes are needed.

Expand All @@ -94,6 +125,7 @@ When adding new features that add confugration options, please ensure the `READM
If you've fixed a bug, please consider adding a unit test to the `/tests` folder that reproduces the original bug without the change.

Try to identify the root cause of the issue and fix the issue. Pull requests that simply add null checks to hide issues are unlikely to be accepted.
>>>>>>> master

Please include instructions how to test the changes.

Expand All @@ -105,18 +137,152 @@ We encourage liberal use of the comments, including images where appropriate.

Most cgm-remote-monitor hackers use github's ticketing system, along with Facebook cgm-in-the-cloud, and gitter.

<<<<<<< HEAD
We use [git-flow](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow), with `master` as our production, stable branch, and
`dev` is used to queue changes for upcoming releases. Everything else is
done on branches, hopefully with names that indicate what to expect.

Once `dev` has been reviewed and people feel it's time to release, we
follow the git-flow release process, which creates a new tag and bumps
the version correctly. See [sem-ver](https://semver.org/) for versioning strategy.

Every commit is tested by Travis CI. We encourage adding tests to
validate your design. We encourage discussing your use cases to help
everyone get a better understanding of your design.
=======
We use git-flow, with `master` as our production, stable branch, and `dev` is used to queue up for upcoming releases. Everything else is done on branches, hopefully with names that indicate what to expect.

Once `dev` has been reviewed and people feel it's time to release, we follow the git-flow release process, which creates a new tag and bumps the version correctly. See sem-ver for versioning strategy.

Every commit is tested by travis. We encourage adding tests to validate your design. We encourage discussing your use cases to help everyone get a better understanding of your design.
>>>>>>> master

## Other Dev Tips

* Join the [Gitter chat][gitter-url]
* Get a local dev environment setup if you haven't already
* Try breaking up big features/improvements into small parts. It's much easier to accept small PR's
* Create tests for your new code, and for the old code too. We are aiming for a full test coverage.
* If your going to be working in old code that needs lots of reformatting consider doing the clean as a separate PR.
* If you can find others to help test your PR is will help get them merged in sooner.
* Get a local dev environment setup if you haven't already.
* Try breaking up big features/improvements into small parts. It's much easier to accept small PR's.
* Create tests for your new code as well as the old code. We are aiming for a full test coverage.
* If you're going to be working in old code that needs lots of reformatting, consider doing it as a separate PR.
* If you can find others to help test your PR, it will help get them merged in sooner.

## List of Contributors

We welcome new contributors. We do not only need core contributors. Regular or one time contributors are welcomed as well.
Also if you can't code, it's possible to contribute by improving the documentation or by translating Nightscout in your own language

### Core developers, contributing developers, coordinators and documentation writers

[@andrew-warrington]: https://github.com/andrew-warrington
[@apanasef]: https://github.com/apanasef
[@bewest]: https://github.com/bewest
[@danamlewis]: https://github.com/danamlewis
[@herzogmedia]: https://github.com/herzogmedia
[@jamieowendexcom ]: https://github.com/jamieowendexcom
[@jasoncalabrese]: https://github.com/jasoncalabrese
[@jizhongwen]: https://github.com/jizhongwen
[@jpcunningh]: https://github.com/jpcunningh
[@jweismann]: https://github.com/jweismann
[@komarserjio]: https://github.com/komarserjio
[@LuminaryXion]: https://github.com/LuminaryXion
[@mcdafydd]: https://github.com/mcdafydd
[@mdomox]: https://github.com/mdomox
[@MilosKozak]: https://github.com/MilosKozak
[@oteroos]: https://github.com/oteroos
[@PieterGit]: https://github.com/PieterGit
[@rarneson]: https://github.com/rarneson
[@rickfriele]: https://github.com/rickfriele
[@scottleibrand]: https://github.com/scottleibrand
[@sulkaharo]: https://github.com/sulkaharo
[@tynbendad]: https://github.com/tynbendad
[@unsoluble]: https://github.com/unsoluble
[@viderehh]: https://github.com/viderehh

| Contribution area | List of contributors |
| ------------------------------------- | ---------------------------------- |
| Core developers: | [@jasoncalabrese] [@MilosKozak] [@PieterGit] [@sulkaharo] |
| Former Core developers: (not active): | [@bewest] |
| Contributing developers: | [@jpcunningh] [@scottleibrand] [@komarserjio] [@jweismann] |
| Release coordination 0.10.x: | [@PieterGit] [@sulkaharo] |
| Release coordination 0.11.x: | [@PieterGit] |
| Issue/Pull request coordination: | Please volunteer |
| Cleaning up git fork spam: | Please volunteer |
| Documentation writers: | [@andrew-warrington][@unsoluble] [@tynbendad] [@danamlewis] [@rarneson] |

### Plugin contributors

| Contribution area | List of developers | List of testers
| ------------------------------------- | -------------------- | -------------------- |
| [`alexa` (Amazon Alexa)](README.md#alexa-amazon-alexa)| Please volunteer | Please volunteer |
| [`ar2` (AR2 Forecasting)](README.md#ar2-ar2-forecasting)| Please volunteer | Please volunteer |
| [`basal` (Basal Profile)](README.md#basal-basal-profile)| Please volunteer | Please volunteer |
| [`boluscalc` (Bolus Wizard)](README.md#boluscalc-bolus-wizard)| Please volunteer | Please volunteer |
| [`bridge` (Share2Nightscout bridge)](README.md#bridge-share2nightscout-bridge)| Please volunteer | Please volunteer |
| [`bwp` (Bolus Wizard Preview)](README.md#bwp-bolus-wizard-preview)| Please volunteer | Please volunteer |
| [`cage` (Cannula Age)](README.md#cage-cannula-age)| [@jpcunningh] | Please volunteer |
| [`careportal` (Careportal)](README.md#careportal-careportal)| Please volunteer | Please volunteer |
| [`cob` (Carbs-on-Board)](README.md#cob-carbs-on-board)| Please volunteer | Please volunteer |
| [`cors` (CORS)](README.md#cors-cors)| Please volunteer | Please volunteer |
| [`delta` (BG Delta)](README.md#delta-bg-delta)| Please volunteer | Please volunteer |
| [`devicestatus` (Device Status)](README.md#devicestatus-device-status)| Please volunteer | Please volunteer |
| [`direction` (BG Direction)](README.md#direction-bg-direction)| Please volunteer | Please volunteer |
| [`errorcodes` (CGM Error Codes)](README.md#errorcodes-cgm-error-codes)| Please volunteer | Please volunteer |
| [`food` (Custom Foods)](README.md#food-custom-foods)| Please volunteer | Please volunteer |
| [`googlehome` (Google Home)](README.md#google-home) |[@mdomox] [@rickfriele] | [@mcdafydd] [@oteroos] [@jamieowendexcom] |
| [`iage` (Insulin Age)](README.md#iage-insulin-age)| Please volunteer | Please volunteer |
| [`iob` (Insulin-on-Board)](README.md#iob-insulin-on-board)| Please volunteer | Please volunteer |
| [`loop` (Loop)](README.md#loop-loop)| Please volunteer | Please volunteer |
| [`mmconnect` (MiniMed Connect bridge)](README.md#mmconnect-minimed-connect-bridge)| Please volunteer | Please volunteer |
| [`openaps` (OpenAPS)](README.md#openaps-openaps)| Please volunteer | Please volunteer |
| [`profile` (Treatment Profile)](README.md#profile-treatment-profile)| Please volunteer | Please volunteer |
| [`pump` (Pump Monitoring)](README.md#pump-pump-monitoring)| Please volunteer | Please volunteer |
| [`rawbg` (Raw BG)](README.md#rawbg-raw-bg)| [@jpcunningh] | Please volunteer |
| [`sage` (Sensor Age)](README.md#sage-sensor-age)| @jpcunningh | Please volunteer |
| [`simplealarms` (Simple BG Alarms)](README.md#simplealarms-simple-bg-alarms)| Please volunteer | Please volunteer |
| [`speech` (Speech)](README.md#speech-speech) | [@sulkaharo] | Please volunteer |
| [`timeago` (Time Ago)](README.md#timeago-time-ago)| Please volunteer | Please volunteer |
| [`treatmentnotify` (Treatment Notifications)](README.md#treatmentnotify-treatment-notifications)| Please volunteer | Please volunteer |
| [`upbat` (Uploader Battery)](README.md#upbat-uploader-battery)| [@jpcunningh] | Please volunteer |
| [`xdrip-js` (xDrip-js)](README.md#xdrip-js-xdrip-js)| [@jpcunningh] | Please volunteer |

### Translators

See `/translations` of your Nightscout, to view the current translation coverage and the missing items.
Languages with less than 90% coverage will be removed in a future Nightscout versions.

| Language | List of translators | Status
| ------------- | -------------------- |-------------------- |
| Български (`bg`) |Please volunteer| OK |
| Čeština (`cs`) |Please volunteer|OK |
| Deutsch (`de`) |[@viderehh] [@herzogmedia] |OK |
| Dansk (`dk`) |Please volunteer|OK |
| Ελληνικά `(el`)|Please volunteer|Needs attention: 68.5%|
| English (`en`)|Please volunteer|OK|
| Español (`es`) |Please volunteer|OK|
| Suomi (`fi`)|[@sulkaharo] |OK|
| Français (`fr`)|Please volunteer|OK|
| עברית (`he`)|Please volunteer|OK|
| Hrvatski (`hr`)|Please volunteer|Needs attention: 47.8%|
| Italiano (`it`)|Please volunteer|OK|
| 日本語 (`ja`)|[@LuminaryXion]|Working on this|
| 한국어 (`ko`)|Please volunteer|Needs attention: 80.6%|
| Norsk (Bokmål) (`nb`)|Please volunteer|OK|
| Nederlands (`nl`)|[@PieterGit]|OK|
| Polski (`pl`)|Please volunteer|OK|
| Português (Brasil) (`pt`)|Please volunteer|OK|
| Română (`ro`)|Please volunteer|OK|
| Русский (`ru`)|[@apanasef]|OK|
| Slovenčina (`sk`)|Please volunteer|OK|
| Svenska (`sv`)|Please volunteer|OK|
| 中文(简体) (`zh_cn`) | [@jizhongwen]|OK|
| 中文(繁體) (`zh_tw`) | [@jizhongwen]|Needs attention: 25.0%
| 日本語 (`ja_jp`) | [@LuminaryXion]|


### List of all contributors
| Contribution area | List of contributors |
| ------------------------------------- | -------------------- |
| All active developers: | [@jasoncalabrese] [@jpcunningh] [@jweismann] [@komarserjio] [@mdomox] [@MilosKozak] [@PieterGit] [@rickfriele] [@sulkaharo]
| All active testers/documentors: | [@danamlewis] [@jamieowendexcom] [@mcdafydd] [@oteroos] [@rarneson] [@tynbendad] [@unsoluble]
| All active translators: | [@apanasef] [@jizhongwen] [@viderehh] [@herzogmedia] [@LuminaryXion]

3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ MOCHA=./node_modules/mocha/bin/_mocha
# Pinned from dependency list.
ISTANBUL=./node_modules/.bin/istanbul
ANALYZED=./coverage/lcov.info
export CODACY_REPO_TOKEN=e29ae5cf671f4f918912d9864316207c
# Following token deprecated
# export CODACY_REPO_TOKEN=e29ae5cf671f4f918912d9864316207c

DOCKER_IMAGE=nightscout/cgm-remote-monitor-travis

Expand Down
Loading