-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Улучшения декоратора #11
Merged
nixel2007
merged 4 commits into
nixel2007:master
from
sfaqer:feature/decoratorImprovements
Mar 26, 2023
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
82a6e9d
1. Добавлено наследование приватных полей декорируемых классов для то…
sfaqer ca1e504
Добавлен красный тест на странное поведение
sfaqer 3ddda23
Отказ от использования Вычислить и Выполнить в методах
sfaqer 659e944
Из шаблона декоратора удалены ставшие не нужными поля:
sfaqer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
// BSLLS:CodeOutOfRegion-off | ||
Описание.Имя("decorator") | ||
.Версия("1.4.1") | ||
.Версия("1.5.0") | ||
.Автор("Nikita Gryzlov") | ||
.АдресАвтора("[email protected]") | ||
.Описание("Библиотека для создания декораторов над объектами") | ||
.ВерсияСреды("1.8.2") | ||
.ВерсияСреды("1.8.3") | ||
.ВерсияМанифеста("1.0.0") | ||
.ВключитьФайл("src") | ||
.ВключитьФайл("docs") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,45 @@ | ||
// {АннотацияМетода} | ||
Функция Декоратор_ИмяМетода(Декоратор_ОписаниеПараметровМетода) // {Экспорт} | ||
{Функция} Декоратор_ИмяМетода(Декоратор_ОписаниеПараметровМетода) // {Экспорт} | ||
|
||
Декоратор_ЗначениеПоля = Декоратор_Рефлектор.ПолучитьСвойство( | ||
ЭтотОбъект, | ||
Константы_Декоратор.Поле_ИнстансОбъекта | ||
); | ||
|
||
Если {Декоратор_ЭтоДекорируемыйМетод} Тогда | ||
ОбработкаДекоратора.СинхронизироватьПоля(ЭтотОбъект, Декоратор_ЗначениеПоля); | ||
Иначе | ||
ОбработкаДекоратора.СинхронизироватьПоля(Декоратор_ЗначениеПоля, ЭтотОбъект); | ||
КонецЕсли; | ||
|
||
Декоратор_ВозвращаемоеИзМетодаЗначение = NULL; | ||
|
||
// {Декоратор_ПередВызовомМетода} | ||
|
||
// {Декоратор_ТекстМетода} | ||
|
||
// {Декоратор_ТипМетода} | ||
|
||
Декоратор_Лог.Отладка(Декоратор_ТипМетода); | ||
|
||
// {Декоратор_ВыполняемаяСтрока}; | ||
|
||
Если {Декоратор_ЭтоДекорируемыйМетод} Тогда | ||
ОбработкаДекоратора.СинхронизироватьПоля(Декоратор_ЗначениеПоля, ЭтотОбъект); | ||
Иначе | ||
ОбработкаДекоратора.СинхронизироватьПоля(ЭтотОбъект, Декоратор_ЗначениеПоля); | ||
КонецЕсли; | ||
|
||
Если Декоратор_ВозвращаемоеИзМетодаЗначение = Декоратор_ЗначениеПоля Тогда | ||
Декоратор_ВозвращаемоеИзМетодаЗначение = ЭтотОбъект; | ||
КонецЕсли; | ||
|
||
// {Декоратор_ПослеВызоваМетода} | ||
|
||
КонецФункции | ||
|
||
// {Декоратор_ВозвращаемоеЗначение} | ||
|
||
{КонецФункции} | ||
|
||
{Функция} ДекораторВнутренний_ИмяМетода(Декоратор_ОписаниеПараметровМетода) | ||
|
||
// {Декоратор_ТекстМетода} | ||
|
||
{КонецФункции} |
30 changes: 0 additions & 30 deletions
30
src/internal/Классы/ШаблонТелоМетодаДекоратора.os_template
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А осени на этом методе был дикая просадка перфоманса. Тебе не хватит обращения к Декоратор_ИсходныйОбъект напрямую?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Выпилил ненужные поля и почистил шаблон метода