Fix letsencrypt tests, user type definition and getSubmodules function #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #64.
I just tried to pretty much implement what @infinisil proposed in the issue as nix is still quite a bit of magic to me...
This PR only works for 20.03, NOT for 19.09 (the submodule magic from infinisil doesn't work without his change in nixpkgs..) and on unstable the test suite can't run through. Infinisil recommended to make it backwards compatible but I really don't know how to do this.
My approach would be to simply create different branches for the different channels as it seems like there are quite some things that have changed... Or create a
19.09
Tag on the last commit that works on that channel...I tried to fix the tests and it seems to me like they run successful on the 20.03 channel. I also use this commit on a personal mailserver without issues until now. On unstable the test suite seems to log this in an endless loop:
after this:
I don't know what the problem is there, the tests are still a bit too much magic for me to understand. If you could help me with that and also run the tests on 20.03 I would be really glad.
I'd like to get rid of all the deprecation warnings (e.g. perl tests instead of python tests or users as list instead of set) so that the bump to 20.09 will work later on. But before that the tests should at least run successfully on unstable...