Fixed ptrace::Request cfg conditions #892
Merged
+54
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Apr 28, 2018
|
@asomers Thnak you for your comment, I applied line-wrap, and added CHANGELOG entry. |
asomers
reviewed
Apr 29, 2018
CHANGELOG.md
Outdated
| @@ -51,6 +51,8 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| ([#833](https://github.com/nix-rust/nix/pull/833)) | |||
| - `ioctl_write_int!` now properly supports passing a `c_ulong` as the parameter on Linux non-musl targets | |||
| ([#833](https://github.com/nix-rust/nix/pull/833)) | |||
| - Fixed `ptrace::Request` cfg conditions | |||
There was a problem hiding this comment.
How about "Enabled more ptrace::Request definitions for uncommon Linux platforms"?
There was a problem hiding this comment.
I'll change to it.
Should it be moved to Added or Changed section?
There was a problem hiding this comment.
Ehh, it could go either way. Maybe Changed would be best.
There was a problem hiding this comment.
I moved it to Changed setcion.
dalance
force-pushed
the
fix_ptrace_request_cfg
branch
from
8e0e904 to
42ffc88
Compare
dalance
force-pushed
the
fix_ptrace_request_cfg
branch
from
42ffc88 to
1dda866
Compare
|
I squashed and changed commit message. |
asomers
approved these changes
Apr 29, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 29, 2018
892: Fixed ptrace::Request cfg conditions r=asomers a=dalance The cfg condition of ptrace::Request seems to be different from libc. For example, PTRACE_GETREGS is defined by libc to i686-unknown-linux-gnu target, but it is not defined in ptrace::Request. I tried to change the cfg condition to the same as libc's condition. I thinks this change covers the definitions under src/unix/notbsd directory in libc repository. Co-authored-by: dalance <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cfg condition of ptrace::Request seems to be different from libc.
For example, PTRACE_GETREGS is defined by libc to i686-unknown-linux-gnu target, but it is not defined in ptrace::Request.
I tried to change the cfg condition to the same as libc's condition.
I thinks this change covers the definitions under src/unix/notbsd directory in libc repository.