ci: drop official support for rustc < 1.7.0 #444
Conversation
|
I'm ok with this so long as we mention it in the changelog and make it a "major" bump to 0.8. |
|
(Seeing how this review business works) |
|
As my issue #432 indicates, I'm all for it. Given changes are made as suggested by @kamalmarhubi r=me (or him I suppose :)). |
Ah, missed that. I'm still a big fan of having a minimum supported version that is tested by CI, but I agree that we don't need to support ancient versions. Even 1.7 is older than I think we need to support, but that is where CI is at present. More discussion on that over at rust-embedded/wg#16
Will do. |
Supporting older verisons of rust is causing CI to fail and is a somewhat constant support burden with questionable value. 1.7.0 is the oldest I have seen that people have had a requirement on supporting in recent history. It may make sense to work toward a more official policy on what version of rust we will support in the future. Users of older version of rust are, of course, welcome to use older versions of nix and everything else in the ecosystem. Signed-off-by: Paul Osborne <[email protected]>
Also, changed author from Carl to being more broad (as we have many contributors and maintainers now). This matches what is used for crates in the rust-lang org. Signed-off-by: Paul Osborne <[email protected]>
posborne
force-pushed
the
rust-1.7-minimum-supported-version
branch
from
ae517b1 to
360f7aa
Compare
|
@homu r=kamalmarhubi |
|
📌 Commit 360f7aa has been approved by |
…amalmarhubi ci: drop official support for rustc < 1.7.0 Supporting older versions of rust is causing CI to fail and is a somewhat constant support burden with questionable value. 1.7.0 is the oldest I have seen that people have had a requirement on supporting in recent history. It may make sense to work toward a more official policy on what version of rust we will support in the future. Users of older version of rust are, of course, welcome to use older versions of nix and everything else in the ecosystem. r? @kamalmarhubi @fiveop
|
As a note, I have now also enabled nightly builds via https://nightli.es/ which I have been using on other projects for some time. This will give us a better indication of when things may be broken on a new stable/beta/nightly release without having a contributor bump into it first. |
|
☀️ Test successful - status |
|
@posborne does nightlies have a dashboard? |
They have a page called the dashboard when logged in. It basically just shows rust projects under your account and whether nightli.es has setup webhooks or not. Code is here: https://github.com/coderanger/nightlies. It is quite barebones but will get us notifications via travis when things start failing. |
|
Thought of an additional benefit bumping tro 1.7 is that we get |
Supporting older versions of rust is causing CI to fail and is
a somewhat constant support burden with questionable value. 1.7.0
is the oldest I have seen that people have had a requirement on
supporting in recent history.
It may make sense to work toward a more official policy on
what version of rust we will support in the future. Users of
older version of rust are, of course, welcome to use older versions
of nix and everything else in the ecosystem.
r? @kamalmarhubi @fiveop