Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide accessors to sigmask of UContext. #370

Merged
merged 1 commit into from
Jun 28, 2016
Merged

Provide accessors to sigmask of UContext. #370

merged 1 commit into from
Jun 28, 2016

Conversation

fiveop
Copy link
Contributor

@fiveop fiveop commented May 5, 2016

No description provided.

@@ -22,4 +23,13 @@ impl UContext {
};
Errno::result(res).map(drop)
}

#[allow(mutable_transmutes)]
pub fn mut_sigmask(&mut self) -> &mut SigSet {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mut_sigmask or sigmask_mut?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For DerefMut it's deref_mut, so I went with sigmask_mut.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another example that supports my choice of name:

rust-lang/rust@9370d3a

@fiveop
Copy link
Contributor Author

fiveop commented Jun 26, 2016

Can we merge this now?

@posborne
Copy link
Member

Looks good. @homu r+

@homu
Copy link
Contributor

homu commented Jun 27, 2016

📌 Commit dbcf792 has been approved by posborne

homu added a commit that referenced this pull request Jun 27, 2016
Provide accessors to sigmask of UContext.
@homu
Copy link
Contributor

homu commented Jun 27, 2016

⌛ Testing commit dbcf792 with merge 9c6c71a...

@homu
Copy link
Contributor

homu commented Jun 28, 2016

☀️ Test successful - status

@homu homu merged commit dbcf792 into nix-rust:master Jun 28, 2016
@fiveop fiveop deleted the context branch June 29, 2016 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants