-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide accessors to sigmask of UContext. #370
Conversation
@@ -22,4 +23,13 @@ impl UContext { | |||
}; | |||
Errno::result(res).map(drop) | |||
} | |||
|
|||
#[allow(mutable_transmutes)] | |||
pub fn mut_sigmask(&mut self) -> &mut SigSet { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mut_sigmask
or sigmask_mut
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For DerefMut
it's deref_mut
, so I went with sigmask_mut
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another example that supports my choice of name:
Can we merge this now? |
Looks good. @homu r+ |
📌 Commit dbcf792 has been approved by |
Provide accessors to sigmask of UContext.
☀️ Test successful - status |
No description provided.