Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sys::socket::consts::MSG_* #352

Closed
wants to merge 2 commits into from
Closed

Added sys::socket::consts::MSG_* #352

wants to merge 2 commits into from

Conversation

maennchen
Copy link

Partially solve #316.

@fiveop
Copy link
Contributor

fiveop commented Apr 14, 2016

Thank you for the PR. However, #316 is about getting the constants defined in rust-lang/libc and then use those constants for our bitflags. I would prefer adding the constants to libc first, because they have testing infrastructure in place that checks if the constants are defined with the same values in C headers.

@kamalmarhubi
Copy link
Member

Ah the description in #316 is a bit unclear. I'll update it.

@homu
Copy link
Contributor

homu commented Sep 9, 2016

☔ The latest upstream changes (presumably #422) made this pull request unmergeable. Please resolve the merge conflicts.

@kamalmarhubi
Copy link
Member

Triaging PRs, and closing this one for inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants