Improvements and new syscalls #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abbradar thanks for the PR! I'll review the commits in order. In the meantime, could you address the CI issues? Looks like unused var and import. |
|
@abbradar after looking, could you actually split each commit to its own PR? Some only have nits, others I'd rather hold off on. It's easier if I can merge each independently. Closing this in the meantime. |
|
No problem! Thank you very much for the review. |
|
:-) |
This was referenced Feb 19, 2016
Merged
homu
added a commit
that referenced
this pull request
Feb 19, 2016
mqueue: change types to allow more cases Part of #270, fixed according to @kamalmarhubi's comments.
This was referenced Feb 19, 2016
Merged
|
I've submitted things that required only small changes -- I'll work at others later. |
homu
added a commit
that referenced
this pull request
Feb 19, 2016
mqueue: change types to allow more cases Part of #270, fixed according to @kamalmarhubi's comments.
homu
added a commit
that referenced
this pull request
Feb 19, 2016
mqueue: change types to allow more cases Part of #270, fixed according to @kamalmarhubi's comments.
homu
added a commit
that referenced
this pull request
Feb 19, 2016
select(2) fixes Part of #270, fixed according to @kamalmarhubi's comments.
homu
added a commit
that referenced
this pull request
Feb 20, 2016
mqueue: change types to allow more cases Part of #270, fixed according to @kamalmarhubi's comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This most likely should have been split for the review, but I don't see how except for maybe splitting each commit into its own PR -- each change is independent of other ones.