Implement NixPath for str and OsStr #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arcnmx any thoughts? I realized on the way to this that we're currently doing a terrible job of interior NULs. There's nothing new on that front in this PR, as you can have interior NULs in a |
kamalmarhubi
force-pushed
the
nixpath-str-osstr
branch
from
a880a9d to
77a3c10
Compare
|
Seems fine to me! Interior nuls should probably trigger invalidpath errors, just like they do in |
This is a stop gap improvement until the NixPath reform is figured out. refs nix-rust#221
kamalmarhubi
force-pushed
the
nixpath-str-osstr
branch
from
77a3c10 to
9f7c9fb
Compare
|
Great, rebased, waiting for CI then will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stop gap improvement until the NixPath reform is figured out.
refs #221