Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AT_EACCESS to AtFlags on all platforms #1995

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Add AT_EACCESS to AtFlags on all platforms #1995

merged 1 commit into from
Feb 10, 2023

Conversation

MatteoNardi
Copy link
Contributor

@MatteoNardi MatteoNardi commented Feb 1, 2023 •
edited
Loading

On Linux, I need the AT_EACCESS flag for faccessat:

AT_EACCESS
       Perform access checks using the effective user and group IDs.  By default, faccessat() uses the real IDs (like access()).

This commit is enabling it for all platforms but redox. I'm not really sure if this is correct of I should have just added a target_os = "linux". A did quick git grep -e AT_EACCESS -e 'AT_REMOVEDIR' on libc and it showed they're available on the same targets, so for consistence I just removed the cfg limitation. CI was helpful and showed me I was wrong: it's undefined on android.

asomers
asomers approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 10, 2023

Build succeeded:

@bors bors bot merged commit b2318f9 into nix-rust:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatteoNardi @asomers