Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CANbus socket family protocol constants. #1912

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Added CANbus socket family protocol constants. #1912

merged 1 commit into from
Dec 14, 2022

Conversation

fpagliughi
Copy link
Contributor

Added CANbus socket family protocol values for CanRaw and CanBcm

This was referenced Dec 5, 2022
Open
Closed
asomers
asomers requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a CHANGELOG.

@fpagliughi fpagliughi requested a review from asomers December 9, 2022 23:33
asomers
asomers requested changes Dec 10, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/sys/socket/mod.rs Outdated Show resolved Hide resolved
@fpagliughi
Copy link
Contributor Author

fpagliughi commented Dec 11, 2022 •
edited
Loading

It looks like a CI task failed due to an artificial limit on the number of community tasks. But I can't figure out how to rerun the check(s) from my end.

@fpagliughi fpagliughi requested a review from asomers December 11, 2022 18:29
asomers
asomers reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now you just need to squash your commits. The failed CI job completed after I restarted it.

asomers
asomers approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@fpagliughi
Copy link
Contributor Author

Thanks, @asomers

@bors
Copy link
Contributor

bors bot commented Dec 14, 2022

Build succeeded:

@bors bors bot merged commit b7cb456 into nix-rust:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpagliughi @asomers