Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip ci] edit CHANGELOG formatting prior to 0.24.0 release #1691

Merged
merged 2 commits into from
Mar 26, 2022
Merged

[skip ci] edit CHANGELOG formatting prior to 0.24.0 release #1691

merged 2 commits into from
Mar 26, 2022

Conversation

asomers
Copy link
Member

@asomers asomers commented Mar 25, 2022

No description provided.

@asomers asomers requested a review from rtzoeller March 25, 2022 23:03
@rtzoeller
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request Mar 25, 2022
@bors @asomers
Merge #1691
e51b49c 
1691: [skip ci] edit CHANGELOG formatting prior to 0.24.0 release r=rtzoeller a=asomers



Co-authored-by: Alan Somers <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 25, 2022

Build failed:

@asomers
Copy link
Member Author

asomers commented Mar 25, 2022

Looks like Redox can no longer compile with the toolchain it recommends. Maybe we should switch to standard nightly?

@rtzoeller
Copy link
Collaborator

Looks like Redox can no longer compile with the toolchain it recommends. Maybe we should switch to standard nightly?

I have no objections to switching to the latest nightly, or pinning to a more recent one.

@asomers
Use the nightly toolchain for Redox
333d03b 
The latest redox-syscall crate requires at least Rust 1.59.0, but they
don't define an MSRV policy.  And the version given in the
rust-toolchain file in the Redox repository doesn't work.  So until they
clarify their MSRV, use nightly.

https://gitlab.redox-os.org/redox-os/syscall/-/commit/30f29c32952343412bb6c36c9fda136d26e9431f
@rtzoeller
Copy link
Collaborator

bors retry

@bors
Copy link
Contributor

bors bot commented Mar 26, 2022

Build succeeded:

@bors bors bot merged commit c59a8c8 into master Mar 26, 2022
@asomers asomers deleted the changelog-0.24.0 branch August 12, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asomers @rtzoeller